public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ilya Verbin <iverbin@gmail.com>
To: "Dominique d'Humières" <dominiq@lps.ens.fr>
Cc: bvmaks@gmail.com, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: Tests for libgomp based on OpenMP Examples 4.0.2
Date: Wed, 15 Jul 2015 13:37:00 -0000	[thread overview]
Message-ID: <20150715131325.GB39852@msticlxl57.ims.intel.com> (raw)
In-Reply-To: <F95C56BB-4319-4465-8A39-5A1FC6A07B37@lps.ens.fr>

On Wed, Jul 15, 2015 at 12:29:53 +0200, Dominique d'Humières wrote:
> > The patch replaces all FP comparisons with inequalities and epsilons
> > in those tests for libgomp.
> In libgomp/testsuite/libgomp.fortran/examples-4/simd-8.f90
> 
> integer, parameter :: EPS = 0.005
> 
> should be
> 
> real, parameter :: EPS = 0.005

Committed as obvious.


2015-07-15  Maxim Blumenthal  <maxim.blumenthal@intel.com>

	* testsuite/libgomp.fortran/examples-4/simd-8.f90: (main): Change type
	of EPS parameter from integer to real.
	* testsuite/libgomp.fortran/examples-4/task_dep-5.f90: (check): Change
	type of EPS parameter from integer to real.


diff --git a/libgomp/testsuite/libgomp.fortran/examples-4/simd-8.f90 b/libgomp/testsuite/libgomp.fortran/examples-4/simd-8.f90
index ba7b0f9..3c7869d 100644
--- a/libgomp/testsuite/libgomp.fortran/examples-4/simd-8.f90
+++ b/libgomp/testsuite/libgomp.fortran/examples-4/simd-8.f90
@@ -36,7 +36,7 @@ program simd_8f
   implicit none
   real :: pri, arr(1000), diff
   integer :: i
-  integer, parameter :: EPS = 0.005
+  real, parameter :: EPS = 0.005
 
   do i = 1, 1000
      P(i)   = i
diff --git a/libgomp/testsuite/libgomp.fortran/examples-4/task_dep-5.f90 b/libgomp/testsuite/libgomp.fortran/examples-4/task_dep-5.f90
index f12b42c..0746531 100644
--- a/libgomp/testsuite/libgomp.fortran/examples-4/task_dep-5.f90
+++ b/libgomp/testsuite/libgomp.fortran/examples-4/task_dep-5.f90
@@ -44,7 +44,7 @@ contains
   subroutine check (N, A, B)
     integer :: N
     integer :: i, j
-    integer, parameter :: EPS = 0.000001
+    real, parameter :: EPS = 0.000001
     real, dimension(N,N) :: A, B
     real :: diff
     do i = 1, N


  -- Ilya

  reply	other threads:[~2015-07-15 13:13 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-15 10:49 Dominique d'Humières
2015-07-15 13:37 ` Ilya Verbin [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-07-07 16:48 Maxim Blumental
2015-07-07 17:08 ` Maxim Blumental
2015-07-07 18:17   ` Jakub Jelinek
2015-07-07 18:30     ` Ilya Verbin
2015-07-08 12:51       ` Maxim Blumental
2015-07-08 13:00         ` Maxim Blumental
2015-07-09 12:57           ` Maxim Blumental
2015-07-09 14:23             ` Maxim Blumental
2015-07-09 20:14               ` Jakub Jelinek
2015-07-14 13:41                 ` Jakub Jelinek
     [not found]                   ` <CACy_Q+xw79aVfMxHg00LX7OWRqLUKS4LE4QtV=RSqMSS8vV=Vw@mail.gmail.com>
     [not found]                     ` <20150714172935.GM1788@tucnak.redhat.com>
     [not found]                       ` <CACy_Q+x4JiHm_=BaSDmxCXqFJmChh=vvTv+22Xh-9x2br1HUAQ@mail.gmail.com>
2015-07-14 17:46                         ` Maxim Blumental
2015-07-14 18:28                           ` Jakub Jelinek
2015-07-20 19:58                             ` H.J. Lu
2015-07-22 13:57                               ` Maxim Blumental
2015-07-22 14:16                                 ` Jakub Jelinek
2015-07-22 15:12                                   ` Maxim Blumental
2015-07-22 15:30                                     ` Jakub Jelinek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150715131325.GB39852@msticlxl57.ims.intel.com \
    --to=iverbin@gmail.com \
    --cc=bvmaks@gmail.com \
    --cc=dominiq@lps.ens.fr \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).