public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: vogt@linux.vnet.ibm.com
Cc: gcc-patches@gcc.gnu.org, krebbel@linux.vnet.ibm.com
Subject: Re: [PATCH 3/4] S390 -march=native related fixes
Date: Sat, 18 Jul 2015 00:22:00 -0000	[thread overview]
Message-ID: <20150717230926.4E6573CC3@oc7340732750.ibm.com> (raw)
In-Reply-To: <20150717161342.GE22696@linux.vnet.ibm.com> from "Dominik Vogt" at Jul 17, 2015 05:13:42 PM

Dominik Vogt wrote:

> +      opt_esa_zarch = (has_highgprs) ? " -mzarch" : " -mesa";

This will force -mesa on old machines *even in -m64 mode*,
which is wrong and will cause compilation to fail.


> -/* Defaulting rules.  */
>  #ifdef DEFAULT_TARGET_64BIT
> -#define DRIVER_SELF_SPECS					\

This completely removes use of DRIVER_SELF_SPECS for defaulting,
which I introduced back here:
https://gcc.gnu.org/ml/gcc-patches/2003-06/msg03369.html

The reason for using DRIVER_SELF_SPECS as described there is to
make sure we use compatible flags for compiler, assembler and
linker in all cases, even if some of those flags result from
defaulting rules.

If we don't do that, we rely on those components agreeing exactly
in how to default for unspecified options; for example, we want
to give the correct -march flag to the assembler as an additional
verification to detect compiler bugs where the compiler erroneously
generates an incorrect instruction for that architecture.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain
  Ulrich.Weigand@de.ibm.com

  reply	other threads:[~2015-07-17 23:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-17 16:03 [PATCH 0/4] " Dominik Vogt
2015-07-17 16:04 ` [PATCH 1/4] " Dominik Vogt
2015-07-17 16:05 ` [PATCH 2/4] " Dominik Vogt
2015-07-17 16:08 ` [PATCH 3/4] " Dominik Vogt
2015-07-17 16:43   ` Dominik Vogt
2015-07-18  0:22     ` Ulrich Weigand [this message]
2015-07-20 16:10       ` Dominik Vogt
2015-07-21 11:23         ` Ulrich Weigand
2015-07-21 12:53           ` Dominik Vogt
2015-07-21 17:15             ` Ulrich Weigand
2015-07-22 10:54               ` Dominik Vogt
2015-07-23 13:03                 ` Ulrich Weigand
2015-07-17 16:09 ` [PATCH 4/4] " Dominik Vogt
2015-07-24 11:38 ` [PATCH 0/4] " Andreas Krebbel
2015-07-24 14:39   ` Dominik Vogt
2015-07-29 21:19     ` Richard Sandiford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150717230926.4E6573CC3@oc7340732750.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=krebbel@linux.vnet.ibm.com \
    --cc=vogt@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).