From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79537 invoked by alias); 17 Jul 2015 23:09:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 79523 invoked by uid 89); 17 Jul 2015 23:09:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: e06smtp17.uk.ibm.com Received: from e06smtp17.uk.ibm.com (HELO e06smtp17.uk.ibm.com) (195.75.94.113) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Fri, 17 Jul 2015 23:09:33 +0000 Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 18 Jul 2015 00:09:30 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp17.uk.ibm.com (192.168.101.147) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Sat, 18 Jul 2015 00:09:28 +0100 X-MailFrom: uweigand@de.ibm.com X-RcptTo: gcc-patches@gcc.gnu.org Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 44E5517D8042 for ; Sat, 18 Jul 2015 00:10:48 +0100 (BST) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t6HN9Rt037552288 for ; Fri, 17 Jul 2015 23:09:27 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t6HN9RJI031699 for ; Fri, 17 Jul 2015 17:09:27 -0600 Received: from oc7340732750.ibm.com (icon-9-164-190-147.megacenter.de.ibm.com [9.164.190.147]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t6HN9R0i031696; Fri, 17 Jul 2015 17:09:27 -0600 Received: by oc7340732750.ibm.com (Postfix, from userid 500) id 4E6573CC3; Sat, 18 Jul 2015 01:09:26 +0200 (CEST) Subject: Re: [PATCH 3/4] S390 -march=native related fixes To: vogt@linux.vnet.ibm.com Date: Sat, 18 Jul 2015 00:22:00 -0000 From: "Ulrich Weigand" Cc: gcc-patches@gcc.gnu.org, krebbel@linux.vnet.ibm.com In-Reply-To: <20150717161342.GE22696@linux.vnet.ibm.com> from "Dominik Vogt" at Jul 17, 2015 05:13:42 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <20150717230926.4E6573CC3@oc7340732750.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15071723-0029-0000-0000-0000058265AC X-SW-Source: 2015-07/txt/msg01589.txt.bz2 Dominik Vogt wrote: > + opt_esa_zarch = (has_highgprs) ? " -mzarch" : " -mesa"; This will force -mesa on old machines *even in -m64 mode*, which is wrong and will cause compilation to fail. > -/* Defaulting rules. */ > #ifdef DEFAULT_TARGET_64BIT > -#define DRIVER_SELF_SPECS \ This completely removes use of DRIVER_SELF_SPECS for defaulting, which I introduced back here: https://gcc.gnu.org/ml/gcc-patches/2003-06/msg03369.html The reason for using DRIVER_SELF_SPECS as described there is to make sure we use compatible flags for compiler, assembler and linker in all cases, even if some of those flags result from defaulting rules. If we don't do that, we rely on those components agreeing exactly in how to default for unspecified options; for example, we want to give the correct -march flag to the assembler as an additional verification to detect compiler bugs where the compiler erroneously generates an incorrect instruction for that architecture. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com