public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: DJ Delorie <dj@redhat.com>
To: nickc@redhat.com, gcc-patches@gcc.gnu.org
Subject: rx: remove some asserts
Date: Mon, 20 Jul 2015 21:04:00 -0000	[thread overview]
Message-ID: <201507202040.t6KKeibY028481@greed.delorie.com> (raw)


Nick,

There is no need to assert these just to say "not supported" and gcc
may rarely generate addresses from valid code which trigger these
asserts.  Ok?

Index: gcc/config/rx/rx.c
===================================================================
--- gcc/config/rx/rx.c	(revision 225533)
+++ gcc/config/rx/rx.c	(working copy)
@@ -367,14 +367,12 @@ rx_mode_dependent_address_p (const_rtx a
 
 	case SYMBOL_REF:
 	case LABEL_REF:
 	  return true;
 
 	case MULT:
-	  gcc_assert (REG_P (XEXP (addr, 0)));
-	  gcc_assert (CONST_INT_P (XEXP (addr, 1)));
 	  /* REG+REG*SCALE is always mode dependent.  */
 	  return true;
 
 	default:
 	  /* Not recognized, so treat as mode dependent.  */
 	  return true;

             reply	other threads:[~2015-07-20 20:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-20 21:04 DJ Delorie [this message]
2015-07-28  8:14 Nicholas Clifton
2015-08-08  1:09 ` DJ Delorie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201507202040.t6KKeibY028481@greed.delorie.com \
    --to=dj@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).