From: Ilya Verbin <iverbin@gmail.com>
To: Nathan Sidwell <nathan@acm.org>
Cc: Jakub Jelinek <jakub@redhat.com>,
Thomas Schwinge <THOMAS_SCHWINGE@mentor.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: fix gomp offload routine unloading
Date: Tue, 21 Jul 2015 13:25:00 -0000 [thread overview]
Message-ID: <20150721132047.GB350@msticlxl57.ims.intel.com> (raw)
In-Reply-To: <55AE37ED.60900@acm.org>
On Tue, Jul 21, 2015 at 08:15:41 -0400, Nathan Sidwell wrote:
> On 07/21/15 05:51, Jakub Jelinek wrote:
> >On Mon, Jul 20, 2015 at 07:08:55PM -0400, Nathan Sidwell wrote:
> >>2015-07-20 Nathan Sidwell <nathan@codesourcery.com>
> >>
> >> libgomp/
> >> * target.c (gomp_offload_image_to_device): Rename to ...
> >> (gomp_load_image_to_device): ... here.
> >> (GOMP_offload_register): Adjust call.
> >> (gomp_init_device): Likewise.
> >> (gomp_unload_image_from_device): New. Broken out of ...
> >> (GOMP_offload_unregister): ... here. Call it.
> >> (gomp_unload_device): New.
> >> * libgomp.h (gomp_unload_device): Declare.
> >> * oacc-init.c (acc_shutdown_1): Unload from device before deleting
> >> mem maps.
> >>
> >> gcc/
> >> * config/nvptx/mkoffload.c (process): Add destructor call.
> >
> >Ok if also tested on Intel MIC, with a few changes:
>
> Ilya, are you able to test Intel MIC for me?
I don't see any regressions on MIC.
-- Ilya
next prev parent reply other threads:[~2015-07-21 13:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 23:24 Nathan Sidwell
2015-07-21 9:59 ` Jakub Jelinek
2015-07-21 12:49 ` Nathan Sidwell
2015-07-21 13:25 ` Ilya Verbin [this message]
2015-07-21 13:39 ` Nathan Sidwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150721132047.GB350@msticlxl57.ims.intel.com \
--to=iverbin@gmail.com \
--cc=THOMAS_SCHWINGE@mentor.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=nathan@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).