From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29454 invoked by alias); 21 Jul 2015 17:05:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 29444 invoked by uid 89); 21 Jul 2015 17:05:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: e06smtp12.uk.ibm.com Received: from e06smtp12.uk.ibm.com (HELO e06smtp12.uk.ibm.com) (195.75.94.108) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Tue, 21 Jul 2015 17:05:33 +0000 Received: from /spool/local by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 21 Jul 2015 18:05:30 +0100 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 21 Jul 2015 18:05:28 +0100 X-MailFrom: uweigand@de.ibm.com X-RcptTo: gcc-patches@gcc.gnu.org Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 6D26B1B08061 for ; Tue, 21 Jul 2015 18:06:45 +0100 (BST) Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com [9.149.37.250]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t6LH5Sl438994084 for ; Tue, 21 Jul 2015 17:05:28 GMT Received: from d06av09.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t6LH5Skc026886 for ; Tue, 21 Jul 2015 11:05:28 -0600 Received: from oc7340732750.ibm.com (dyn-9-152-213-24.boeblingen.de.ibm.com [9.152.213.24]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t6LH5SOp026881; Tue, 21 Jul 2015 11:05:28 -0600 Received: by oc7340732750.ibm.com (Postfix, from userid 500) id 0AED5B045; Tue, 21 Jul 2015 19:05:27 +0200 (CEST) Subject: Re: [PATCH 3/4] S390 -march=native related fixes To: vogt@linux.vnet.ibm.com Date: Tue, 21 Jul 2015 17:15:00 -0000 From: "Ulrich Weigand" Cc: gcc-patches@gcc.gnu.org In-Reply-To: <20150721124918.GA12596@linux.vnet.ibm.com> from "Dominik Vogt" at Jul 21, 2015 01:49:18 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <20150721170528.0AED5B045@oc7340732750.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15072117-0009-0000-0000-000004E94D6F X-SW-Source: 2015-07/txt/msg01779.txt.bz2 Dominik Vogt wrote: > * config/s390/driver-native.c (s390_host_detect_local_cpu): Handle > processor capabilities with -march=native. > * config/s390/s390.h (MARCH_MTUNE_NATIVE_SPECS): Likewise. > (DRIVER_SELF_SPECS): Likewise. Join specs for 31 and 64 bit. > * (S390_TARGET_BITS_STRING): Macro to simplify specs. (That last "*" is superfluous.) This looks correct to me now, just a cosmetic comment: > +/* Defaulting rules. */ > +#define DRIVER_SELF_SPECS \ > + "%{!m31:%{!m64:-m" S390_TARGET_BITS_STRING "}} ", \ > + MARCH_MTUNE_NATIVE_SPECS, \ > + "%{!mesa:%{!mzarch:%{m31:-mesa}%{m64:-mzarch}}} ", \ > + "%{!march=*:%{mesa:-march=g5}%{mzarch:-march=z900}} " There's no need to add those spaces at the end -- the self specs are all independent string, they don't need to end in a space. Also, I had thought to put MARCH_MTUNE_NATIVE_SPECS right at the top of list, like so: #define DRIVER_SELF_SPECS \ MARCH_MTUNE_NATIVE_SPECS, \ "%{!m31:%{!m64:-m" S390_TARGET_BITS_STRING "}}", \ "%{!mesa:%{!mzarch:%{m31:-mesa}%{m64:-mzarch}}}", \ "%{!march=*:%{mesa:-march=g5}%{mzarch:-march=z900}}" But there should not be any functional difference between the two, it just looks a bit nicer maybe. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com