From: Jakub Jelinek <jakub@redhat.com>
To: Maxim Blumental <bvmaks@gmail.com>
Cc: "H.J. Lu" <hjl.tools@gmail.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Ilya Verbin <iverbin@gmail.com>
Subject: Re: Tests for libgomp based on OpenMP Examples 4.0.2.
Date: Wed, 22 Jul 2015 14:16:00 -0000 [thread overview]
Message-ID: <20150722141222.GN1780@tucnak.redhat.com> (raw)
In-Reply-To: <CACy_Q+xaCEHf=AK0SOkkm5f30e=gRQ+AYdZqJmVXA7fzTs-bbg@mail.gmail.com>
On Wed, Jul 22, 2015 at 04:55:09PM +0300, Maxim Blumental wrote:
> 2015-07-22 Maxim Blumenthal <maxim.blumenthal@intel.com>
>
> PR libgomp/66950
> * testsuite/libgomp.c/examples-4/simd-7.c: Lower the defined constant
> N to 30. Add iterative reference function for Fibonacci numbers
> - fib_ref.
Incorrect changelog. It should be:
* testsuite/libgomp.c/examples-4/simd-7.c (N): Change to 30 from 45.
(fib_ref): New function.
> (fib): Correct corner cases in the recursion.
Why the n == 2 special case? I think only the if (n <= 1) return n;
case is really needed.
> (main): Replace the non-simd loop with fib_ref call.
> * testsuite/libgomp.fortran/examples-4/simd-7.f90: Add iterative
> reference subroutine for Fibonacci numbers - fib_ref.
See above for ChangeLog entry issue.
> (fibonacci): Lower the parameter N to 30. Correct accordingly check for
> the last array element value. Replace the non-simd loop with fib_ref
> call. Remove redundant b_ref array. Remove the comparison of the last
> array element with according Fibbonacci sequence element.
> (fib): Correct corner cases in the recursion.
See above for n == 2 special case.
Jakub
next prev parent reply other threads:[~2015-07-22 14:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 16:48 Maxim Blumental
2015-07-07 17:08 ` Maxim Blumental
2015-07-07 18:17 ` Jakub Jelinek
2015-07-07 18:30 ` Ilya Verbin
2015-07-08 12:51 ` Maxim Blumental
2015-07-08 13:00 ` Maxim Blumental
2015-07-09 12:57 ` Maxim Blumental
2015-07-09 14:23 ` Maxim Blumental
2015-07-09 20:14 ` Jakub Jelinek
2015-07-14 13:41 ` Jakub Jelinek
[not found] ` <CACy_Q+xw79aVfMxHg00LX7OWRqLUKS4LE4QtV=RSqMSS8vV=Vw@mail.gmail.com>
[not found] ` <20150714172935.GM1788@tucnak.redhat.com>
[not found] ` <CACy_Q+x4JiHm_=BaSDmxCXqFJmChh=vvTv+22Xh-9x2br1HUAQ@mail.gmail.com>
2015-07-14 17:46 ` Maxim Blumental
2015-07-14 18:28 ` Jakub Jelinek
2015-07-20 19:58 ` H.J. Lu
2015-07-22 13:57 ` Maxim Blumental
2015-07-22 14:16 ` Jakub Jelinek [this message]
2015-07-22 15:12 ` Maxim Blumental
2015-07-22 15:30 ` Jakub Jelinek
2015-07-15 10:49 Dominique d'Humières
2015-07-15 13:37 ` Ilya Verbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150722141222.GN1780@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=bvmaks@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=iverbin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).