public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: jakub@redhat.com
Cc: nickc@redhat.com (Nick Clifton),
	Andreas.Krebbel@de.ibm.com,
	       gcc-patches@gcc.gnu.org (gcc-patches)
Subject: Re: s390-linux fails to build
Date: Thu, 23 Jul 2015 13:26:00 -0000	[thread overview]
Message-ID: <20150723130329.87834B045@oc7340732750.ibm.com> (raw)
In-Reply-To: <20150723125611.GA1780@tucnak.redhat.com> from "Jakub Jelinek" at Jul 23, 2015 02:56:11 PM

Jakub Jelinek wrote:
> On Thu, Jul 23, 2015 at 02:46:43PM +0200, Ulrich Weigand wrote:
> > > I bet that is gone break also cross-compilers from s390* to other targets.
> > 
> > I think this should be fine on s390.  The problem with i386 is that
> > the driver-native.c file uses data types only defined by the i386
> > target files (e.g. enum processor_type).  But on s390, the file does
> > not any target-specific types and should be fully portable.
> 
> That hunk means that driver-native.o is added to EXTRA_GCC_OBJS
> even say for s390x-*-* -> x86_64-*-* compiler.  While it might compile
> there, nothing will use it, so what is it good for?
> i?86/x86_64 backend will certainly not reference s390_host_detect_local_cpu
> anywhere.

Oh, I agree this will not be *used*.  I just wanted to point out that it
will not *break* cross-compilers as is.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain
  Ulrich.Weigand@de.ibm.com

  reply	other threads:[~2015-07-23 13:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-23 12:18 Nick Clifton
2015-07-23 12:33 ` Jakub Jelinek
2015-07-23 12:56   ` Ulrich Weigand
2015-07-23 13:09     ` Jakub Jelinek
2015-07-23 13:26       ` Ulrich Weigand [this message]
2015-07-23 13:31         ` Jakub Jelinek
2015-07-23 13:44           ` Dominik Vogt
2015-07-24  8:48             ` Dominik Vogt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150723130329.87834B045@oc7340732750.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=Andreas.Krebbel@de.ibm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).