From: Segher Boessenkool <segher@kernel.crashing.org>
To: tbsaunde+gcc@tbsaunde.org
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 4/4] define ASM_OUTPUT_LABEL to the name of a function
Date: Sat, 25 Jul 2015 18:34:00 -0000 [thread overview]
Message-ID: <20150725155919.GA12288@gate.crashing.org> (raw)
In-Reply-To: <1437791820-17927-5-git-send-email-tbsaunde+gcc@tbsaunde.org>
On Fri, Jul 24, 2015 at 10:37:00PM -0400, tbsaunde+gcc@tbsaunde.org wrote:
> --- a/gcc/config/pa/pa.c
> +++ b/gcc/config/pa/pa.c
> @@ -9761,6 +9761,18 @@ pa_reloc_rw_mask (void)
> return 3;
> }
>
> +/* Assemble a lable. */
Typo.
> +void
> +pa_output_label (FILE *f, const char *label)
> +{
> + assemble_name (f, label);
> + if (TARGET_GAS)
> + fputs (":\n", f);
> + else
> + fputc ('\n', (f));
You forgot to remove the extra parens here :-)
If so many targets use default_assemble_label, can you make it an actual
default instead of defining it everywhere?
Segher
next prev parent reply other threads:[~2015-07-25 15:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-25 2:37 [PATCH 0/4] misc work to get rid of target macros tbsaunde+gcc
2015-07-25 2:37 ` [PATCH 3/4] remove unused TARGET_DEFERRED_OUTPUT_DEFS tbsaunde+gcc
2015-07-31 0:55 ` Joseph Myers
2015-07-25 2:37 ` [PATCH 1/4] convert ASM_OUTPUT_ASCII to a hook tbsaunde+gcc
2015-07-25 6:22 ` pinskia
2015-07-25 19:44 ` Trevor Saunders
2015-07-25 17:02 ` Segher Boessenkool
2015-07-27 20:51 ` Richard Sandiford
2015-07-25 3:09 ` [PATCH 2/4] make TLS_COMMON_ASM_OP " tbsaunde+gcc
2015-07-25 5:42 ` [PATCH 4/4] define ASM_OUTPUT_LABEL to the name of a function tbsaunde+gcc
2015-07-25 18:34 ` Segher Boessenkool [this message]
2015-07-25 19:27 ` Trevor Saunders
2015-07-25 19:44 ` Segher Boessenkool
2015-07-27 9:17 ` Richard Biener
2015-07-28 6:45 ` Trevor Saunders
2015-07-29 23:05 ` Jeff Law
2015-08-05 10:58 ` Trevor Saunders
2015-08-05 11:47 ` Richard Biener
2015-08-05 13:38 ` Trevor Saunders
2015-08-05 13:59 ` Richard Biener
2015-08-05 22:28 ` Segher Boessenkool
2015-08-05 15:28 ` David Malcolm
2015-08-05 15:34 ` David Malcolm
2015-08-05 20:23 ` Trevor Saunders
2015-08-06 18:48 ` David Malcolm
2015-08-06 19:36 ` Richard Sandiford
2015-08-07 4:32 ` Trevor Saunders
2015-08-07 9:46 ` Richard Sandiford
2015-08-07 13:50 ` Trevor Saunders
2015-08-07 20:24 ` Richard Biener
2015-08-07 21:52 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150725155919.GA12288@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tbsaunde+gcc@tbsaunde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).