From: Trevor Saunders <tbsaunde@tbsaunde.org>
To: Jeff Law <law@redhat.com>,
Richard Biener <richard.guenther@gmail.com>,
tbsaunde+gcc@tbsaunde.org, GCC Patches <gcc-patches@gcc.gnu.org>,
rdsandiford@googlemail.com
Subject: Re: [PATCH 0/9] start converting POINTER_SIZE to a hook
Date: Tue, 28 Jul 2015 05:52:00 -0000 [thread overview]
Message-ID: <20150728034406.GB23293@tsaunders-iceball.corp.tor1.mozilla.com> (raw)
In-Reply-To: <87a8uhfjt7.fsf@googlemail.com>
On Mon, Jul 27, 2015 at 09:05:08PM +0100, Richard Sandiford wrote:
> Jeff Law <law@redhat.com> writes:
> > On 07/27/2015 03:17 AM, Richard Biener wrote:
> >> On Mon, Jul 27, 2015 at 5:10 AM, <tbsaunde+gcc@tbsaunde.org> wrote:
> >>> From: Trevor Saunders <tbsaunde+gcc@tbsaunde.org>
> >>>
> >>> Hi,
> >>>
> >>> $subject.
> >>>
> >>> patches individually bootstrapped + regtested on x86_64-linux-gnu, and run
> >>> through config-list.mk with more patches removing usage of the macro. Ok?
> >>
> >> With POINTER_SIZE now being expensive (target hook) you might consider
> >> moving most users to use pointer_sized_int_node or some other global
> >> derived from POINTER_SIZE.
> >>
> >> Which of course raises the question of why we are hookizing this... if you'd
> >> want a truly switchable target you'd have to switch all global trees as well
> >> (or hookize them individually).
> > Not sure -- it doesn't remove any conditionally compiled code...
> >
> > One could easily argue that it's just another step on the path towards a
> > switchable target -- which in and of itself is a reasonable design goal.
> >
> > Trevor, maybe a quick note on the motivation would help here...
>
> I think at least we should use data hooks rather than function hooks,
> since this value should a constant within a subtarget. It should only
> change for target_reinit.
I agree in principal, but I wasn't sure where all I might need to change
the values of the hooks, and of course I wondered if there might be some
crazy target where that's not good enough.
> Alternatively we could have a new target_globals structure that is
> initialised with the result of calling the hook. If we do that though,
> it might make sense to consolidate the hooks rather than have one for
> every value. E.g. having one function for UNITS_PER_WORD, one for
> POINTER_SIZE, one for Pmode, etc., would lead to some very verbose
> target code.
so something like
struct target_types
{
unsigned long pointer_size;
...
};
const target_types &targetm.get_type_data ()
? that seems pretty reasonable, and I wouldn't expect too many ordering
issues, but who knows. Its too bad nobody has taken on the big job of
turning targetm into a class so we can hope for some devirt help from
the compiler.
thanks!
Trev
>
> Perhaps the main problem with these approaches is ensuring that the
> value is set up early enough.
>
> Thanks,
> Richard
next prev parent reply other threads:[~2015-07-28 3:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 3:10 tbsaunde+gcc
2015-07-27 3:10 ` [PATCH 7/9] stor-layout.c: switch to targetm.pointer_size () tbsaunde+gcc
2015-07-27 3:10 ` [PATCH 2/9] add pointer_size target hook tbsaunde+gcc
2015-07-27 3:10 ` [PATCH 5/9] ubsan.c: switch from POINTER_SIZE to targetm.pointer_size () tbsaunde+gcc
2015-07-27 3:10 ` [PATCH 3/9] target.h: change to use targetm.pointer_size instead of POINTER_SIZE tbsaunde+gcc
2015-07-27 3:10 ` [PATCH 1/9] remove POINTER_SIZE_UNITS macro tbsaunde+gcc
2015-07-27 3:10 ` [PATCH 4/9] varasm.c: switch from POINTER_SIZE to targetm.pointer_size () tbsaunde+gcc
2015-07-27 9:32 ` Richard Biener
2015-07-27 3:10 ` [PATCH 9/9] emit-rtl.c: switch " tbsaunde+gcc
2015-07-27 3:42 ` [PATCH 6/9] tree-chkp.c: " tbsaunde+gcc
2015-07-27 3:49 ` [PATCH 8/9] tree.c: " tbsaunde+gcc
2015-07-27 9:26 ` [PATCH 0/9] start converting POINTER_SIZE to a hook Richard Biener
2015-07-27 16:20 ` Jeff Law
2015-07-27 20:15 ` Richard Sandiford
2015-07-28 5:52 ` Trevor Saunders [this message]
2015-07-28 20:36 ` Richard Sandiford
2015-07-29 4:44 ` Trevor Saunders
2015-07-29 8:32 ` Richard Sandiford
2015-07-30 8:13 ` Trevor Saunders
2015-07-30 22:30 ` Richard Sandiford
2015-07-28 3:47 ` Trevor Saunders
2015-07-29 10:40 ` Richard Earnshaw
2015-07-30 4:55 ` Segher Boessenkool
2015-07-30 13:42 David Edelsohn
2015-07-30 22:26 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150728034406.GB23293@tsaunders-iceball.corp.tor1.mozilla.com \
--to=tbsaunde@tbsaunde.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=rdsandiford@googlemail.com \
--cc=richard.guenther@gmail.com \
--cc=tbsaunde+gcc@tbsaunde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).