From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Mikael Morin <mikael.morin@sfr.fr>
Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] PR fortran/66942 -- avoid referencing a NULL C++ thing
Date: Tue, 28 Jul 2015 13:38:00 -0000 [thread overview]
Message-ID: <20150728131925.GA63678@troutmask.apl.washington.edu> (raw)
In-Reply-To: <55B77DF4.3070209@sfr.fr>
On Tue, Jul 28, 2015 at 03:04:52PM +0200, Mikael Morin wrote:
> Le 21/07/2015 21:08, Steve Kargl a ?crit :
> > When C++ was injected into trans-expr.c in the form of vec,
> > it seems whomever did the conversion to vec forgot to check
> > for a NULL C++ thing. This patch seems to avoid the problem,
> > but having zero knowledge of C++ I could be wrong.
> >
> > OK for trunk?
> >
> > 2015-07-21 Steven G. Kargl <kargl@gcc.gnu.org>
> >
> > PR fortran/66942
> > * trans-expr.c (gfc_conv_procedure_call): Avoid dereferencing NULL
> > C++ thing.
> >
> Hello Steve,
>
> I believe the vec API should have all that is necessary to handle this
> automatically.
> Did you try using vec_safe_splice?
>
I know zero about vec and I know zero about C++.
--
Steve
next prev parent reply other threads:[~2015-07-28 13:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 19:49 Steve Kargl
2015-07-28 13:19 ` Mikael Morin
2015-07-28 13:38 ` Steve Kargl [this message]
2015-07-29 8:35 ` Richard Biener
2015-07-29 9:59 ` Mikael Morin
2015-07-29 11:57 ` Richard Biener
2015-07-29 12:04 ` Mikael Morin
2015-07-29 12:25 ` Richard Biener
2015-07-29 17:23 ` Steve Kargl
2015-07-30 14:41 ` Mikael Morin
2015-08-03 16:58 ` Steve Kargl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150728131925.GA63678@troutmask.apl.washington.edu \
--to=sgk@troutmask.apl.washington.edu \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=mikael.morin@sfr.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).