From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77848 invoked by alias); 30 Jul 2015 00:14:49 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 77836 invoked by uid 89); 30 Jul 2015 00:14:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 30 Jul 2015 00:14:47 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id t6U0EeV2030769; Wed, 29 Jul 2015 19:14:40 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id t6U0EdLP030768; Wed, 29 Jul 2015 19:14:39 -0500 Date: Thu, 30 Jul 2015 04:55:00 -0000 From: Segher Boessenkool To: Richard Earnshaw Cc: tbsaunde+gcc@tbsaunde.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH 0/9] start converting POINTER_SIZE to a hook Message-ID: <20150730001438.GA28541@gate.crashing.org> References: <1437966615-21093-1-git-send-email-tbsaunde+gcc@tbsaunde.org> <55B8A808.3020303@foss.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55B8A808.3020303@foss.arm.com> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg02532.txt.bz2 On Wed, Jul 29, 2015 at 11:16:40AM +0100, Richard Earnshaw wrote: > I'm getting a bit worried about the potential performance impact from > all these indirect function call hooks. This is a good example of when > it's probably somewhat unnecessary. I doubt that the compiler could > function correctly if this ever changed in the middle of a function. It is also very ugly and much harder to read: it is longer, with more useless interpunction, and there is nothing that makes clear it is a constant. Segher