From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33383 invoked by alias); 31 Jul 2015 16:46:49 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 33374 invoked by uid 89); 31 Jul 2015 16:46:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 31 Jul 2015 16:46:43 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 6F31A8E3F0; Fri, 31 Jul 2015 16:46:42 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-30.ams2.redhat.com [10.36.116.30]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6VGkeCL010957 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 31 Jul 2015 12:46:41 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id t6VGkdLK030744; Fri, 31 Jul 2015 18:46:39 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id t6VGkcMo030743; Fri, 31 Jul 2015 18:46:38 +0200 Date: Fri, 31 Jul 2015 16:52:00 -0000 From: Jakub Jelinek To: Kai Tietz Cc: Jason Merrill , Jeff Law , Kai Tietz , gcc-patches List Subject: Re: C++ delayed folding branch review Message-ID: <20150731164638.GH1780@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <557BAE5A.7030309@redhat.com> <55B661A1.6090308@redhat.com> <55B911DD.30105@redhat.com> <55BA5667.9040200@redhat.com> <55BAE20A.1070400@redhat.com> <55BB9EDB.8030305@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg02693.txt.bz2 On Fri, Jul 31, 2015 at 06:25:57PM +0200, Kai Tietz wrote: > 2015-07-31 18:14 GMT+02:00 Jason Merrill : > > On 07/30/2015 10:48 PM, Jeff Law wrote: > >> > >> Note, anything outside of the C/C++ front-ends depending on that > >> canonicalization done by shorten_compare is, IMHO, broken. > > > > > > I think the OMP code isn't relying on it being done by shorten_compare; it's > > trying to do it itself in c_finish_omp_for but is somehow thwarted by > > delayed folding. > > > > Jason > > > > Well, this seems to be reasoned by finish_omp_for (), which gets > invoked in parser.c cp_parser_omp_for_loop, and/or pt.c: tsubst_expr. > In all those cases arguments aren't folded anymore. So > c_finish_omp_for's patterns don't match anymore. I guess we might > want to do this cannonical form in genericize-pass? Or just fold in finish_omp_for before calling c_finish_omp_for, so that it is in the expected form? Jakub