From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4299 invoked by alias); 1 Aug 2015 09:28:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 4288 invoked by uid 89); 1 Aug 2015 09:28:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mo-sw.iij4u.or.jp Received: from mo-sw1500.iij4u.or.jp (HELO mo-sw.iij4u.or.jp) (210.130.239.240) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sat, 01 Aug 2015 09:28:19 +0000 Received: by mo-sw.iij4u.or.jp (4u-mo-sw1500) id t719S8RQ005921; Sat, 1 Aug 2015 18:28:08 +0900 Received: from localhost (24.26.30.125.dy.iij4u.or.jp [125.30.26.24]) by mbox.iij4u.or.jp (4u-mbox1500) id t719S6Ec017064; Sat, 1 Aug 2015 18:28:07 +0900 Date: Sat, 01 Aug 2015 09:28:00 -0000 Message-Id: <20150801.182806.389139551.kkojima@rr.iij4u.or.jp> To: richard.sandiford@arm.com Cc: gcc-patches@gcc.gnu.org Subject: Re: Use cmpstr and cmpstrn optabs From: Kaz Kojima In-Reply-To: <87k2tglf9g.fsf@e105548-lin.cambridge.arm.com> References: <87k2tglf9g.fsf@e105548-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00003.txt.bz2 Richard Sandiford wrote: > This patch converts the code to do everything via the optabs interface. > This required a change to the sh.md cmpstrn pattern, where the length > predicate was "immediate_operand" but where the expander code wanted > to handle nonimmediates too. I also removed the now-redundant > force_operand of the length in the rx.md pattern (because the > predicate is now enforced and already an operand). > > The check whether "target" has insn_mode is performed by > create_output_operand so we no longer need to check it in > the builtins.c code too. > > Bootstrapped & regression-tested on x86_64-linux-gnu. Also tested by > building ft32-elf, s390x-linux-gnu, m32c-elf, rx-elf and sh4-elf > and checking that (with the appropriate target flags) the optabs > are working for various strcmp and strncmp calls. OK to install? SH portion looks fine. No new failures with the patch on sh4-unknown-linux-gnu. Regards, kaz