From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37830 invoked by alias); 3 Aug 2015 09:59:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 37819 invoked by uid 89); 3 Aug 2015 09:59:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: cam-smtp0.cambridge.arm.com Received: from fw-tnat.cambridge.arm.com (HELO cam-smtp0.cambridge.arm.com) (217.140.96.140) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 03 Aug 2015 09:59:47 +0000 Received: from arm.com (e106375-lin.cambridge.arm.com [10.2.207.23]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id t739xhot018426; Mon, 3 Aug 2015 10:59:43 +0100 Date: Mon, 03 Aug 2015 09:59:00 -0000 From: James Greenhalgh To: Kyrill Tkachov Cc: GCC Patches , Marcus Shawcroft , Richard Earnshaw Subject: Re: [PATCH][AArch64][3/14] Refactor option override code Message-ID: <20150803095943.GA8841@arm.com> References: <55A7CBC5.3030201@arm.com> <20150720164426.GA20088@arm.com> <55B1F59A.9010309@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55B1F59A.9010309@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00036.txt.bz2 On Fri, Jul 24, 2015 at 09:21:46AM +0100, Kyrill Tkachov wrote: > > Thanks for the review, here's an updated version. > In the end, I chose to retain the use alloca (other patches in the series > are reworked to use it too). > > How's this? A nit or two from code you were moving or that got caught up in the diff, but otherwise OK to commit with the issues highlighted below fixed up. > > - aarch64_build_bitmask_table (); > +/* Validate a command-line -mcpu option. Parse the cpu and extensions (if any) > + specified in STR and throw errors if appropriate. Put the results if > + they are valid in RES and ISA_FLAGS. */ > +static void > +aarch64_validate_mcpu (const char *str, const struct processor **res, > + unsigned long *isa_flags) Newline between comment and function. > +/* Validate a command-line -march option. Parse the arch and extensions > + (if any) specified in STR and throw errors if appropriate. Put the > + results, if they are valid, in RES and ISA_FLAGS. */ > +static void > +aarch64_validate_march (const char *str, const struct processor **res, > + unsigned long *isa_flags) And here. > +/* Validate a command-line -mtune option. Parse the cpu > + specified in STR and throw errors if appropriate. Put the > + result, if it is valid, in RES. */ > +static void > +aarch64_validate_mtune (const char *str, const struct processor **res) And here. Thanks, James