From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110727 invoked by alias); 10 Aug 2015 14:57:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 110713 invoked by uid 89); 10 Aug 2015 14:57:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.5 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Aug 2015 14:57:28 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CE44375 for ; Mon, 10 Aug 2015 07:57:25 -0700 (PDT) Received: from e105545-lin (e105545-lin.cambridge.arm.com [10.2.206.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ADA5A3F23A; Mon, 10 Aug 2015 07:57:26 -0700 (PDT) Date: Mon, 10 Aug 2015 14:57:00 -0000 From: Ramana Radhakrishnan To: Matthew Wahab Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 1/2][ARM] Record FPU features as a bit-set Message-ID: <20150810145722.GA32034@e105545-lin> References: <558826B0.401@arm.com> <55C87CB6.3090402@foss.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55C87CB6.3090402@foss.arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00467.txt.bz2 On Mon, Aug 10, 2015 at 11:28:06AM +0100, Matthew Wahab wrote: > Ping. Updated patch attached. > > Also, retested the series for arm-none-linux-gnueabihf with native > bootstrap and make check. > > On 22/06/15 16:16, Matthew Wahab wrote: > >Hello, > > > >The ARM backend records FPU features as booleans, one for each feature. This > >means that adding support for a new feature involves updating every entry in the > >list of FPU descriptions in arm-fpus.def. This patch series changes the > >representation of FPU features to use a simple bit-set and flags, as is done > >elsewhere. > > > >This patch adds the new FPU feature representation, with feature sets > >represented as unsigned longs. > > > >Tested the series for arm-none-linux-gnueabihf with check-gcc > > > >Ok for trunk? > >Matthew This is OK, thanks Ramana > > > >gcc/ > >2015-06-22 Matthew Wahab > > > > * config/arm/arm.h (arm_fpu_fset): New. > > (ARM_FPU_FSET_HAS): New. > > (FPU_FL_NONE): New. > > (FPU_FL_NEON): New. > > (FPU_FL_FP16): New. > > (FPU_FL_CRYPTO): New. > > > > From 571416d9e7bc9cb6c16008486faf357873270991 Mon Sep 17 00:00:00 2001 > From: Matthew Wahab > Date: Thu, 23 Jul 2015 12:44:51 +0100 > Subject: [PATCH 1/2] Add fpu feature set definitions. > > Change-Id: I9f0fcc9627e3c435cbbc9056b9244781b438447e > --- > gcc/config/arm/arm.h | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/gcc/config/arm/arm.h b/gcc/config/arm/arm.h > index bb64be0..f49eb48 100644 > --- a/gcc/config/arm/arm.h > +++ b/gcc/config/arm/arm.h > @@ -318,6 +318,19 @@ extern void (*arm_lang_output_object_attributes_hook)(void); > {"mode", "%{!marm:%{!mthumb:-m%(VALUE)}}"}, \ > {"tls", "%{!mtls-dialect=*:-mtls-dialect=%(VALUE)}"}, > > +/* FPU feature sets. */ > + > +typedef unsigned long arm_fpu_feature_set; > + > +/* Test for an FPU feature. */ > +#define ARM_FPU_FSET_HAS(S,F) (((S) & (F)) == (F)) > + > +/* FPU Features. */ > +#define FPU_FL_NONE (0) > +#define FPU_FL_NEON (1 << 0) /* NEON instructions. */ > +#define FPU_FL_FP16 (1 << 1) /* Half-precision. */ > +#define FPU_FL_CRYPTO (1 << 2) /* Crypto extensions. */ > + > /* Which floating point model to use. */ > enum arm_fp_model > { > -- > 1.9.1 >