From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106553 invoked by alias); 14 Aug 2015 13:29:52 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 106541 invoked by uid 89); 14 Aug 2015 13:29:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 14 Aug 2015 13:29:50 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 1270FABE; Fri, 14 Aug 2015 13:29:49 +0000 (UTC) Received: from redhat.com (ovpn-204-94.brq.redhat.com [10.40.204.94]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7EDTjrO022177 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Fri, 14 Aug 2015 09:29:48 -0400 Date: Fri, 14 Aug 2015 13:36:00 -0000 From: Marek Polacek To: Richard Biener Cc: GCC Patches Subject: Re: [PATCH] Fix middle-end/67133, part 1 Message-ID: <20150814132945.GS3335@redhat.com> References: <20150814112006.GR3335@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-08/txt/msg00789.txt.bz2 On Fri, Aug 14, 2015 at 03:14:10PM +0200, Richard Biener wrote: > On Fri, Aug 14, 2015 at 1:20 PM, Marek Polacek wrote: > > As outlined in the PR, this fixes one ICE. The code in question here > > tries to determine whether OP can be derived as non-NULL. In case the > > function has the nonnull attribute that applies to all the arguments, > > we want to see whether OP is in this argument list. But nonnull only > > appertains to pointers. Some ssa_names don't have a type so check for > > that first instead of segv before looking at its tree code. > > Huh? All but released SSA names have a type. So this gets invoked on dead code I suppose so. It gets def_stmt version 13 in-free-list> (it didn't ICE before r209891 because the operand_equal_p check came first and returned false so we didn't check the type). Marek