* [PATCH] Fix ICE with bogus posix_memalign call (PR middle-end/67222)
@ 2015-08-17 18:38 Marek Polacek
2015-08-18 8:50 ` Richard Biener
0 siblings, 1 reply; 6+ messages in thread
From: Marek Polacek @ 2015-08-17 18:38 UTC (permalink / raw)
To: GCC Patches
Here we were crashing on an invalid call to posix_memalign. The code in
lower_builtin_posix_memalign assumed that the call had valid arguments.
The reason the C FE doesn't reject this code is, in short, that
int <T> () is compatible with int <T> (void **, size_t, size_t) and we
use the former -- so convert_arguments doesn't complain.
So I think let's validate the arguments in lower_stmt. I decided to
give an error if we see an invalid usage of posix_memalign, since
other code (e.g. alias machinery) assumes correct arguments as well.
Bootstrapped/regtested on x86_64-linux, ok for trunk?
2015-08-17 Marek Polacek <polacek@redhat.com>
PR middle-end/67222
* gimple-low.c: Include "builtins.h".
(lower_stmt): Validate arguments of posix_memalign.
* gcc.dg/torture/pr67222.c: New test.
diff --git gcc/gimple-low.c gcc/gimple-low.c
index d4697e2..03194f0 100644
--- gcc/gimple-low.c
+++ gcc/gimple-low.c
@@ -39,6 +39,7 @@ along with GCC; see the file COPYING3. If not see
#include "langhooks.h"
#include "gimple-low.h"
#include "tree-nested.h"
+#include "builtins.h"
/* The differences between High GIMPLE and Low GIMPLE are the
following:
@@ -345,10 +346,22 @@ lower_stmt (gimple_stmt_iterator *gsi, struct lower_data *data)
data->cannot_fallthru = false;
return;
}
- else if (DECL_FUNCTION_CODE (decl) == BUILT_IN_POSIX_MEMALIGN
- && flag_tree_bit_ccp)
+ else if (DECL_FUNCTION_CODE (decl) == BUILT_IN_POSIX_MEMALIGN)
{
- lower_builtin_posix_memalign (gsi);
+ if (gimple_call_num_args (stmt) != 3
+ || !validate_gimple_arglist (dyn_cast <gcall *> (stmt),
+ POINTER_TYPE, INTEGER_TYPE,
+ INTEGER_TYPE, VOID_TYPE))
+ {
+ error_at (gimple_location (stmt), "invalid arguments "
+ "to %qD", decl);
+ gsi_next (gsi);
+ return;
+ }
+ if (flag_tree_bit_ccp)
+ lower_builtin_posix_memalign (gsi);
+ else
+ gsi_next (gsi);
return;
}
}
diff --git gcc/testsuite/gcc.dg/torture/pr67222.c gcc/testsuite/gcc.dg/torture/pr67222.c
index e69de29..cf39aa1 100644
--- gcc/testsuite/gcc.dg/torture/pr67222.c
+++ gcc/testsuite/gcc.dg/torture/pr67222.c
@@ -0,0 +1,19 @@
+/* { dg-do compile } */
+/* { dg-options "-Wno-implicit-function-declaration" } */
+
+void
+foo (void **p)
+{
+ posix_memalign (); /* { dg-error "invalid arguments" } */
+ posix_memalign (p); /* { dg-error "invalid arguments" } */
+ posix_memalign (0); /* { dg-error "invalid arguments" } */
+ posix_memalign (p, 1); /* { dg-error "invalid arguments" } */
+ posix_memalign (p, "foo"); /* { dg-error "invalid arguments" } */
+ posix_memalign ("gnu", "gcc"); /* { dg-error "invalid arguments" } */
+ posix_memalign (1, p); /* { dg-error "invalid arguments" } */
+ posix_memalign (1, 2); /* { dg-error "invalid arguments" } */
+ posix_memalign (1, 2, 3); /* { dg-error "invalid arguments" } */
+ posix_memalign (p, p, p); /* { dg-error "invalid arguments" } */
+ posix_memalign (p, "qui", 3); /* { dg-error "invalid arguments" } */
+ posix_memalign (p, 1, 2);
+}
Marek
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix ICE with bogus posix_memalign call (PR middle-end/67222)
2015-08-17 18:38 [PATCH] Fix ICE with bogus posix_memalign call (PR middle-end/67222) Marek Polacek
@ 2015-08-18 8:50 ` Richard Biener
2015-08-18 10:43 ` Marek Polacek
0 siblings, 1 reply; 6+ messages in thread
From: Richard Biener @ 2015-08-18 8:50 UTC (permalink / raw)
To: Marek Polacek; +Cc: GCC Patches
On Mon, Aug 17, 2015 at 8:01 PM, Marek Polacek <polacek@redhat.com> wrote:
> Here we were crashing on an invalid call to posix_memalign. The code in
> lower_builtin_posix_memalign assumed that the call had valid arguments.
> The reason the C FE doesn't reject this code is, in short, that
> int <T> () is compatible with int <T> (void **, size_t, size_t) and we
> use the former -- so convert_arguments doesn't complain.
>
> So I think let's validate the arguments in lower_stmt. I decided to
> give an error if we see an invalid usage of posix_memalign, since
> other code (e.g. alias machinery) assumes correct arguments as well.
>
> Bootstrapped/regtested on x86_64-linux, ok for trunk?
I don't think you can give errors here. Note that the "appropriate"
way to do the check is to simply use
if (gimple_builtin_call_types_compatible_p (stmt, decl))
not lowering in case it's not compatible is ok.
Thanks,
Richard.
> 2015-08-17 Marek Polacek <polacek@redhat.com>
>
> PR middle-end/67222
> * gimple-low.c: Include "builtins.h".
> (lower_stmt): Validate arguments of posix_memalign.
>
> * gcc.dg/torture/pr67222.c: New test.
>
> diff --git gcc/gimple-low.c gcc/gimple-low.c
> index d4697e2..03194f0 100644
> --- gcc/gimple-low.c
> +++ gcc/gimple-low.c
> @@ -39,6 +39,7 @@ along with GCC; see the file COPYING3. If not see
> #include "langhooks.h"
> #include "gimple-low.h"
> #include "tree-nested.h"
> +#include "builtins.h"
>
> /* The differences between High GIMPLE and Low GIMPLE are the
> following:
> @@ -345,10 +346,22 @@ lower_stmt (gimple_stmt_iterator *gsi, struct lower_data *data)
> data->cannot_fallthru = false;
> return;
> }
> - else if (DECL_FUNCTION_CODE (decl) == BUILT_IN_POSIX_MEMALIGN
> - && flag_tree_bit_ccp)
> + else if (DECL_FUNCTION_CODE (decl) == BUILT_IN_POSIX_MEMALIGN)
> {
> - lower_builtin_posix_memalign (gsi);
> + if (gimple_call_num_args (stmt) != 3
> + || !validate_gimple_arglist (dyn_cast <gcall *> (stmt),
> + POINTER_TYPE, INTEGER_TYPE,
> + INTEGER_TYPE, VOID_TYPE))
> + {
> + error_at (gimple_location (stmt), "invalid arguments "
> + "to %qD", decl);
> + gsi_next (gsi);
> + return;
> + }
> + if (flag_tree_bit_ccp)
> + lower_builtin_posix_memalign (gsi);
> + else
> + gsi_next (gsi);
> return;
> }
> }
> diff --git gcc/testsuite/gcc.dg/torture/pr67222.c gcc/testsuite/gcc.dg/torture/pr67222.c
> index e69de29..cf39aa1 100644
> --- gcc/testsuite/gcc.dg/torture/pr67222.c
> +++ gcc/testsuite/gcc.dg/torture/pr67222.c
> @@ -0,0 +1,19 @@
> +/* { dg-do compile } */
> +/* { dg-options "-Wno-implicit-function-declaration" } */
> +
> +void
> +foo (void **p)
> +{
> + posix_memalign (); /* { dg-error "invalid arguments" } */
> + posix_memalign (p); /* { dg-error "invalid arguments" } */
> + posix_memalign (0); /* { dg-error "invalid arguments" } */
> + posix_memalign (p, 1); /* { dg-error "invalid arguments" } */
> + posix_memalign (p, "foo"); /* { dg-error "invalid arguments" } */
> + posix_memalign ("gnu", "gcc"); /* { dg-error "invalid arguments" } */
> + posix_memalign (1, p); /* { dg-error "invalid arguments" } */
> + posix_memalign (1, 2); /* { dg-error "invalid arguments" } */
> + posix_memalign (1, 2, 3); /* { dg-error "invalid arguments" } */
> + posix_memalign (p, p, p); /* { dg-error "invalid arguments" } */
> + posix_memalign (p, "qui", 3); /* { dg-error "invalid arguments" } */
> + posix_memalign (p, 1, 2);
> +}
>
> Marek
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix ICE with bogus posix_memalign call (PR middle-end/67222)
2015-08-18 8:50 ` Richard Biener
@ 2015-08-18 10:43 ` Marek Polacek
2015-08-18 11:08 ` Richard Biener
0 siblings, 1 reply; 6+ messages in thread
From: Marek Polacek @ 2015-08-18 10:43 UTC (permalink / raw)
To: Richard Biener; +Cc: GCC Patches
On Tue, Aug 18, 2015 at 10:47:44AM +0200, Richard Biener wrote:
> On Mon, Aug 17, 2015 at 8:01 PM, Marek Polacek <polacek@redhat.com> wrote:
> > Here we were crashing on an invalid call to posix_memalign. The code in
> > lower_builtin_posix_memalign assumed that the call had valid arguments.
> > The reason the C FE doesn't reject this code is, in short, that
> > int <T> () is compatible with int <T> (void **, size_t, size_t) and we
> > use the former -- so convert_arguments doesn't complain.
> >
> > So I think let's validate the arguments in lower_stmt. I decided to
> > give an error if we see an invalid usage of posix_memalign, since
> > other code (e.g. alias machinery) assumes correct arguments as well.
> >
> > Bootstrapped/regtested on x86_64-linux, ok for trunk?
>
> I don't think you can give errors here. Note that the "appropriate"
> way to do the check is to simply use
Yeah, because the weirdo call is only undefined if it's reached at runtime,
right.
> if (gimple_builtin_call_types_compatible_p (stmt, decl))
Nice, dunno how could I not find that.
> not lowering in case it's not compatible is ok.
In that case I also need to check a place in tree-ssa-alias.c.
Bootstrapped/regtested on x86_64-linux, ok for trunk and 5?
2015-08-18 Marek Polacek <polacek@redhat.com>
PR middle-end/67222
* gimple-low.c (lower_stmt): Check the posix_memalign call.
* tree-ssa-alias.c (call_may_clobber_ref_p_1): Likewise.
* gcc.dg/torture/pr67222.c: New test.
diff --git gcc/gimple-low.c gcc/gimple-low.c
index d4697e2..4eae3a0 100644
--- gcc/gimple-low.c
+++ gcc/gimple-low.c
@@ -346,7 +346,8 @@ lower_stmt (gimple_stmt_iterator *gsi, struct lower_data *data)
return;
}
else if (DECL_FUNCTION_CODE (decl) == BUILT_IN_POSIX_MEMALIGN
- && flag_tree_bit_ccp)
+ && flag_tree_bit_ccp
+ && gimple_builtin_call_types_compatible_p (stmt, decl))
{
lower_builtin_posix_memalign (gsi);
return;
diff --git gcc/testsuite/gcc.dg/torture/pr67222.c gcc/testsuite/gcc.dg/torture/pr67222.c
index e69de29..739f869 100644
--- gcc/testsuite/gcc.dg/torture/pr67222.c
+++ gcc/testsuite/gcc.dg/torture/pr67222.c
@@ -0,0 +1,19 @@
+/* PR middle-end/67222 */
+/* { dg-do compile } */
+
+void
+foo (void **p)
+{
+ posix_memalign (); /* { dg-warning "implicit declaration" } */
+ posix_memalign (p);
+ posix_memalign (0);
+ posix_memalign (p, 1);
+ posix_memalign (p, "foo");
+ posix_memalign ("gnu", "gcc");
+ posix_memalign (1, p);
+ posix_memalign (1, 2);
+ posix_memalign (1, 2, 3);
+ posix_memalign (p, p, p);
+ posix_memalign (p, "qui", 3);
+ posix_memalign (p, 1, 2);
+}
diff --git gcc/tree-ssa-alias.c gcc/tree-ssa-alias.c
index e103220..e96a00c 100644
--- gcc/tree-ssa-alias.c
+++ gcc/tree-ssa-alias.c
@@ -2039,6 +2039,10 @@ call_may_clobber_ref_p_1 (gcall *call, ao_ref *ref)
by its first argument. */
case BUILT_IN_POSIX_MEMALIGN:
{
+ /* For weirdo calls we cannot say much so stay conservative. */
+ tree decl = gimple_call_fndecl (call);
+ if (!gimple_builtin_call_types_compatible_p (call, decl))
+ return true;
tree ptrptr = gimple_call_arg (call, 0);
ao_ref dref;
ao_ref_init_from_ptr_and_size (&dref, ptrptr,
Marek
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix ICE with bogus posix_memalign call (PR middle-end/67222)
2015-08-18 10:43 ` Marek Polacek
@ 2015-08-18 11:08 ` Richard Biener
2015-08-18 12:03 ` Marek Polacek
0 siblings, 1 reply; 6+ messages in thread
From: Richard Biener @ 2015-08-18 11:08 UTC (permalink / raw)
To: Marek Polacek; +Cc: GCC Patches
On Tue, Aug 18, 2015 at 12:28 PM, Marek Polacek <polacek@redhat.com> wrote:
> On Tue, Aug 18, 2015 at 10:47:44AM +0200, Richard Biener wrote:
>> On Mon, Aug 17, 2015 at 8:01 PM, Marek Polacek <polacek@redhat.com> wrote:
>> > Here we were crashing on an invalid call to posix_memalign. The code in
>> > lower_builtin_posix_memalign assumed that the call had valid arguments.
>> > The reason the C FE doesn't reject this code is, in short, that
>> > int <T> () is compatible with int <T> (void **, size_t, size_t) and we
>> > use the former -- so convert_arguments doesn't complain.
>> >
>> > So I think let's validate the arguments in lower_stmt. I decided to
>> > give an error if we see an invalid usage of posix_memalign, since
>> > other code (e.g. alias machinery) assumes correct arguments as well.
>> >
>> > Bootstrapped/regtested on x86_64-linux, ok for trunk?
>>
>> I don't think you can give errors here. Note that the "appropriate"
>> way to do the check is to simply use
>
> Yeah, because the weirdo call is only undefined if it's reached at runtime,
> right.
>
>> if (gimple_builtin_call_types_compatible_p (stmt, decl))
>
> Nice, dunno how could I not find that.
>
>> not lowering in case it's not compatible is ok.
>
> In that case I also need to check a place in tree-ssa-alias.c.
>
> Bootstrapped/regtested on x86_64-linux, ok for trunk and 5?
Please instead change the tree-ssa-alias.c code to do
if (callee != NULL
&& gimple_call_builtin_p (call, BUILT_IN_NORMAL))
switch (DECL_FUNCTION_CODE (callee))
...
which should also fix quite a few issues in the other builtin handlings.
Likewise can you change stmt_kills_ref_p and ref_maybe_used_by_call_p_1
in a similar way?
Thanks,
Richard.
> 2015-08-18 Marek Polacek <polacek@redhat.com>
>
> PR middle-end/67222
> * gimple-low.c (lower_stmt): Check the posix_memalign call.
> * tree-ssa-alias.c (call_may_clobber_ref_p_1): Likewise.
>
> * gcc.dg/torture/pr67222.c: New test.
>
> diff --git gcc/gimple-low.c gcc/gimple-low.c
> index d4697e2..4eae3a0 100644
> --- gcc/gimple-low.c
> +++ gcc/gimple-low.c
> @@ -346,7 +346,8 @@ lower_stmt (gimple_stmt_iterator *gsi, struct lower_data *data)
> return;
> }
> else if (DECL_FUNCTION_CODE (decl) == BUILT_IN_POSIX_MEMALIGN
> - && flag_tree_bit_ccp)
> + && flag_tree_bit_ccp
> + && gimple_builtin_call_types_compatible_p (stmt, decl))
> {
> lower_builtin_posix_memalign (gsi);
> return;
> diff --git gcc/testsuite/gcc.dg/torture/pr67222.c gcc/testsuite/gcc.dg/torture/pr67222.c
> index e69de29..739f869 100644
> --- gcc/testsuite/gcc.dg/torture/pr67222.c
> +++ gcc/testsuite/gcc.dg/torture/pr67222.c
> @@ -0,0 +1,19 @@
> +/* PR middle-end/67222 */
> +/* { dg-do compile } */
> +
> +void
> +foo (void **p)
> +{
> + posix_memalign (); /* { dg-warning "implicit declaration" } */
> + posix_memalign (p);
> + posix_memalign (0);
> + posix_memalign (p, 1);
> + posix_memalign (p, "foo");
> + posix_memalign ("gnu", "gcc");
> + posix_memalign (1, p);
> + posix_memalign (1, 2);
> + posix_memalign (1, 2, 3);
> + posix_memalign (p, p, p);
> + posix_memalign (p, "qui", 3);
> + posix_memalign (p, 1, 2);
> +}
> diff --git gcc/tree-ssa-alias.c gcc/tree-ssa-alias.c
> index e103220..e96a00c 100644
> --- gcc/tree-ssa-alias.c
> +++ gcc/tree-ssa-alias.c
> @@ -2039,6 +2039,10 @@ call_may_clobber_ref_p_1 (gcall *call, ao_ref *ref)
> by its first argument. */
> case BUILT_IN_POSIX_MEMALIGN:
> {
> + /* For weirdo calls we cannot say much so stay conservative. */
> + tree decl = gimple_call_fndecl (call);
> + if (!gimple_builtin_call_types_compatible_p (call, decl))
> + return true;
> tree ptrptr = gimple_call_arg (call, 0);
> ao_ref dref;
> ao_ref_init_from_ptr_and_size (&dref, ptrptr,
>
> Marek
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix ICE with bogus posix_memalign call (PR middle-end/67222)
2015-08-18 11:08 ` Richard Biener
@ 2015-08-18 12:03 ` Marek Polacek
2015-08-18 13:13 ` Richard Biener
0 siblings, 1 reply; 6+ messages in thread
From: Marek Polacek @ 2015-08-18 12:03 UTC (permalink / raw)
To: Richard Biener; +Cc: GCC Patches
On Tue, Aug 18, 2015 at 12:47:45PM +0200, Richard Biener wrote:
> Please instead change the tree-ssa-alias.c code to do
>
> if (callee != NULL
> && gimple_call_builtin_p (call, BUILT_IN_NORMAL))
> switch (DECL_FUNCTION_CODE (callee))
> ...
Ok. I see that works as well because gimple_call_builtin_p uses
gimple_builtin_call_types_compatible_p.
> which should also fix quite a few issues in the other builtin handlings.
> Likewise can you change stmt_kills_ref_p and ref_maybe_used_by_call_p_1
> in a similar way?
Sure. Regtest/bootstrap running, ok for trunk/5 if it passes?
2015-08-18 Marek Polacek <polacek@redhat.com>
PR middle-end/67222
* gimple-low.c (lower_stmt): Don't lower BUILT_IN_POSIX_MEMALIGN
if the call isn't valid.
* tree-ssa-alias.c (ref_maybe_used_by_call_p_1): Check builtins using
gimple_call_builtin_p.
(call_may_clobber_ref_p_1): Likewise.
(stmt_kills_ref_p): Likewise.
* gcc.dg/torture/pr67222.c: New test.
diff --git gcc/gimple-low.c gcc/gimple-low.c
index d4697e2..4eae3a0 100644
--- gcc/gimple-low.c
+++ gcc/gimple-low.c
@@ -346,7 +346,8 @@ lower_stmt (gimple_stmt_iterator *gsi, struct lower_data *data)
return;
}
else if (DECL_FUNCTION_CODE (decl) == BUILT_IN_POSIX_MEMALIGN
- && flag_tree_bit_ccp)
+ && flag_tree_bit_ccp
+ && gimple_builtin_call_types_compatible_p (stmt, decl))
{
lower_builtin_posix_memalign (gsi);
return;
diff --git gcc/testsuite/gcc.dg/torture/pr67222.c gcc/testsuite/gcc.dg/torture/pr67222.c
index e69de29..739f869 100644
--- gcc/testsuite/gcc.dg/torture/pr67222.c
+++ gcc/testsuite/gcc.dg/torture/pr67222.c
@@ -0,0 +1,19 @@
+/* PR middle-end/67222 */
+/* { dg-do compile } */
+
+void
+foo (void **p)
+{
+ posix_memalign (); /* { dg-warning "implicit declaration" } */
+ posix_memalign (p);
+ posix_memalign (0);
+ posix_memalign (p, 1);
+ posix_memalign (p, "foo");
+ posix_memalign ("gnu", "gcc");
+ posix_memalign (1, p);
+ posix_memalign (1, 2);
+ posix_memalign (1, 2, 3);
+ posix_memalign (p, p, p);
+ posix_memalign (p, "qui", 3);
+ posix_memalign (p, 1, 2);
+}
diff --git gcc/tree-ssa-alias.c gcc/tree-ssa-alias.c
index e103220..0445052 100644
--- gcc/tree-ssa-alias.c
+++ gcc/tree-ssa-alias.c
@@ -1535,7 +1535,7 @@ ref_maybe_used_by_call_p_1 (gcall *call, ao_ref *ref)
escape points. See tree-ssa-structalias.c:find_func_aliases
for the list of builtins we might need to handle here. */
if (callee != NULL_TREE
- && DECL_BUILT_IN_CLASS (callee) == BUILT_IN_NORMAL)
+ && gimple_call_builtin_p (call, BUILT_IN_NORMAL))
switch (DECL_FUNCTION_CODE (callee))
{
/* All the following functions read memory pointed to by
@@ -1941,7 +1941,7 @@ call_may_clobber_ref_p_1 (gcall *call, ao_ref *ref)
escape points. See tree-ssa-structalias.c:find_func_aliases
for the list of builtins we might need to handle here. */
if (callee != NULL_TREE
- && DECL_BUILT_IN_CLASS (callee) == BUILT_IN_NORMAL)
+ && gimple_call_builtin_p (call, BUILT_IN_NORMAL))
switch (DECL_FUNCTION_CODE (callee))
{
/* All the following functions clobber memory pointed to by
@@ -2341,7 +2341,7 @@ stmt_kills_ref_p (gimple stmt, ao_ref *ref)
{
tree callee = gimple_call_fndecl (stmt);
if (callee != NULL_TREE
- && DECL_BUILT_IN_CLASS (callee) == BUILT_IN_NORMAL)
+ && gimple_call_builtin_p (stmt, BUILT_IN_NORMAL))
switch (DECL_FUNCTION_CODE (callee))
{
case BUILT_IN_FREE:
Marek
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix ICE with bogus posix_memalign call (PR middle-end/67222)
2015-08-18 12:03 ` Marek Polacek
@ 2015-08-18 13:13 ` Richard Biener
0 siblings, 0 replies; 6+ messages in thread
From: Richard Biener @ 2015-08-18 13:13 UTC (permalink / raw)
To: Marek Polacek; +Cc: GCC Patches
On Tue, Aug 18, 2015 at 1:10 PM, Marek Polacek <polacek@redhat.com> wrote:
> On Tue, Aug 18, 2015 at 12:47:45PM +0200, Richard Biener wrote:
>> Please instead change the tree-ssa-alias.c code to do
>>
>> if (callee != NULL
>> && gimple_call_builtin_p (call, BUILT_IN_NORMAL))
>> switch (DECL_FUNCTION_CODE (callee))
>> ...
>
> Ok. I see that works as well because gimple_call_builtin_p uses
> gimple_builtin_call_types_compatible_p.
>
>> which should also fix quite a few issues in the other builtin handlings.
>> Likewise can you change stmt_kills_ref_p and ref_maybe_used_by_call_p_1
>> in a similar way?
>
> Sure. Regtest/bootstrap running, ok for trunk/5 if it passes?
Ok.
Thanks,
Richard.
> 2015-08-18 Marek Polacek <polacek@redhat.com>
>
> PR middle-end/67222
> * gimple-low.c (lower_stmt): Don't lower BUILT_IN_POSIX_MEMALIGN
> if the call isn't valid.
> * tree-ssa-alias.c (ref_maybe_used_by_call_p_1): Check builtins using
> gimple_call_builtin_p.
> (call_may_clobber_ref_p_1): Likewise.
> (stmt_kills_ref_p): Likewise.
>
> * gcc.dg/torture/pr67222.c: New test.
>
> diff --git gcc/gimple-low.c gcc/gimple-low.c
> index d4697e2..4eae3a0 100644
> --- gcc/gimple-low.c
> +++ gcc/gimple-low.c
> @@ -346,7 +346,8 @@ lower_stmt (gimple_stmt_iterator *gsi, struct lower_data *data)
> return;
> }
> else if (DECL_FUNCTION_CODE (decl) == BUILT_IN_POSIX_MEMALIGN
> - && flag_tree_bit_ccp)
> + && flag_tree_bit_ccp
> + && gimple_builtin_call_types_compatible_p (stmt, decl))
> {
> lower_builtin_posix_memalign (gsi);
> return;
> diff --git gcc/testsuite/gcc.dg/torture/pr67222.c gcc/testsuite/gcc.dg/torture/pr67222.c
> index e69de29..739f869 100644
> --- gcc/testsuite/gcc.dg/torture/pr67222.c
> +++ gcc/testsuite/gcc.dg/torture/pr67222.c
> @@ -0,0 +1,19 @@
> +/* PR middle-end/67222 */
> +/* { dg-do compile } */
> +
> +void
> +foo (void **p)
> +{
> + posix_memalign (); /* { dg-warning "implicit declaration" } */
> + posix_memalign (p);
> + posix_memalign (0);
> + posix_memalign (p, 1);
> + posix_memalign (p, "foo");
> + posix_memalign ("gnu", "gcc");
> + posix_memalign (1, p);
> + posix_memalign (1, 2);
> + posix_memalign (1, 2, 3);
> + posix_memalign (p, p, p);
> + posix_memalign (p, "qui", 3);
> + posix_memalign (p, 1, 2);
> +}
> diff --git gcc/tree-ssa-alias.c gcc/tree-ssa-alias.c
> index e103220..0445052 100644
> --- gcc/tree-ssa-alias.c
> +++ gcc/tree-ssa-alias.c
> @@ -1535,7 +1535,7 @@ ref_maybe_used_by_call_p_1 (gcall *call, ao_ref *ref)
> escape points. See tree-ssa-structalias.c:find_func_aliases
> for the list of builtins we might need to handle here. */
> if (callee != NULL_TREE
> - && DECL_BUILT_IN_CLASS (callee) == BUILT_IN_NORMAL)
> + && gimple_call_builtin_p (call, BUILT_IN_NORMAL))
> switch (DECL_FUNCTION_CODE (callee))
> {
> /* All the following functions read memory pointed to by
> @@ -1941,7 +1941,7 @@ call_may_clobber_ref_p_1 (gcall *call, ao_ref *ref)
> escape points. See tree-ssa-structalias.c:find_func_aliases
> for the list of builtins we might need to handle here. */
> if (callee != NULL_TREE
> - && DECL_BUILT_IN_CLASS (callee) == BUILT_IN_NORMAL)
> + && gimple_call_builtin_p (call, BUILT_IN_NORMAL))
> switch (DECL_FUNCTION_CODE (callee))
> {
> /* All the following functions clobber memory pointed to by
> @@ -2341,7 +2341,7 @@ stmt_kills_ref_p (gimple stmt, ao_ref *ref)
> {
> tree callee = gimple_call_fndecl (stmt);
> if (callee != NULL_TREE
> - && DECL_BUILT_IN_CLASS (callee) == BUILT_IN_NORMAL)
> + && gimple_call_builtin_p (stmt, BUILT_IN_NORMAL))
> switch (DECL_FUNCTION_CODE (callee))
> {
> case BUILT_IN_FREE:
>
> Marek
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-08-18 13:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-17 18:38 [PATCH] Fix ICE with bogus posix_memalign call (PR middle-end/67222) Marek Polacek
2015-08-18 8:50 ` Richard Biener
2015-08-18 10:43 ` Marek Polacek
2015-08-18 11:08 ` Richard Biener
2015-08-18 12:03 ` Marek Polacek
2015-08-18 13:13 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).