From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: vogt@linux.vnet.ibm.com
Cc: gcc-patches@gcc.gnu.org,
Ulrich.Weigand@de.ibm.com (Ulrich Weigand),
krebbel@linux.vnet.ibm.com (Andreas Krebbel)
Subject: Re: [PATCH] S390: Fix vec_load_bndry.
Date: Tue, 18 Aug 2015 12:54:00 -0000 [thread overview]
Message-ID: <20150818124930.EB4EC55DD@oc7340732750.ibm.com> (raw)
In-Reply-To: <20150818121607.GA13922@linux.vnet.ibm.com> from "Dominik Vogt" at Aug 18, 2015 01:16:07 PM
Dominik Vogt wrote:
> The attached patch fixes the vec_load_bndry builtin on S390. The second
> argument must be one of 64, 128, 256, ..., 4096, but the table expected that
> value to fit into 3 bits.
Makes sense. However, I'd really like to see a testcase that verifies
we're accepting the correct values and generate correct assembler ...
> gcc/ChangeLog
>
> * config/s390/s390-builtins.def: S390: Fix value range of
> vec_load_bndry.
The "S390: " seems out of place here.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2015-08-18 12:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 12:38 Dominik Vogt
2015-08-18 12:54 ` Ulrich Weigand [this message]
2015-08-20 8:20 ` Dominik Vogt
2015-08-20 14:33 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150818124930.EB4EC55DD@oc7340732750.ibm.com \
--to=uweigand@de.ibm.com \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=krebbel@linux.vnet.ibm.com \
--cc=vogt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).