From: James Greenhalgh <james.greenhalgh@arm.com>
To: Kyrill Tkachov <kyrylo.tkachov@arm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Marcus Shawcroft <Marcus.Shawcroft@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: [PATCH][AArch64] Use popcount_hwi instead of homebrew version
Date: Wed, 19 Aug 2015 15:16:00 -0000 [thread overview]
Message-ID: <20150819150646.GA746@e107456-lin.cambridge.arm.com> (raw)
In-Reply-To: <55D49A91.9070503@arm.com>
On Wed, Aug 19, 2015 at 04:02:41PM +0100, Kyrill Tkachov wrote:
> Hi all,
>
> I noticed we have a hand-crafted "bit_count" function in the aarch64 backend that implements the popcount operation.
> We already have a midend popcount_hwi function operating on HOST_WIDE_INTs which seems to be exactly what we need.
>
> This patch removes the aarch64-specific version and updates the one callsite where it's used, the '%P' output operand,
> which itself is only used by the *andim_ashift<mode>_bfiz pattern in aarch64.md.
>
> Bootstrapped and tested on aarch64.
>
> Ok for trunk?
OK. A change like this which performs useful cleanup is borderline
obvious.
Thanks,
James
>
> Thanks,
> Kyrill
>
> 2015-08-19 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
>
> * config/aarch64/aarch64.c (bit_count): Delete prototype
> and definition.
> (aarch64_print_operand): Use popcount_hwi instead of the above.
prev parent reply other threads:[~2015-08-19 15:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 15:05 Kyrill Tkachov
2015-08-19 15:16 ` James Greenhalgh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150819150646.GA746@e107456-lin.cambridge.arm.com \
--to=james.greenhalgh@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).