From: James Greenhalgh <james.greenhalgh@arm.com>
To: Andrew Pinski <pinskia@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCHv2/AARCH64] Remove index from AARCH64_EXTRA_TUNING_OPTION
Date: Wed, 19 Aug 2015 16:14:00 -0000 [thread overview]
Message-ID: <20150819160834.GB37938@e107456-lin.cambridge.arm.com> (raw)
In-Reply-To: <CA+=Sn1kfkh36aXzJgBYi0ZQC5aoeddEmAZY29T7u3aVBVtSsGw@mail.gmail.com>
On Wed, Aug 19, 2015 at 05:00:14PM +0100, Andrew Pinski wrote:
> Just like the patch for AARCH64_FUSION_PAIR, this is a patch for
> AARCH64_EXTRA_TUNING_OPTION. Note I tested this patch on top of the
> patch for AARCH64_EXTRA_TUNING_OPTION.
>
> Changes in v2:
> Remove the hack for AARCH64_EXTRA_TUNE_ALL.
>
> Remove index from AARCH64_EXTRA_TUNING_OPTION
>
> Instead of doing an explict index in aarch64-tuning-flags.def, we
> should have an enum which does the index instead. This allows
> you to add/remove them without worrying about the order being
> correct and having holes or worry about merge conficts.
>
> OK? Bootstrapped and tested on aarch64-linux-gnu with no regressions.
-ENOPATCH, but assuming this is along the same lines as the one I just
acked, I'm happy for you to consider this preapproved (after checking
the comments below). Please send a copy to the list for the archives.
> ChangeLog:
> * config/aarch64/aarch64-tuning-flags.def: Remove all index to
> AARCH64_EXTRA_TUNING_OPTION.
> * config/aarch64/aarch64-protos.h (extra_tuning_flags_index): New enum.
I'm guessing that this has a more aarch64-centric name like
aarch64_extra_tuning_flags_index ? If not, it probably should have just to
fit with the naming scheme in the rest of the file.
> (aarch64_extra_tuning_flags): Base the shifted value on the index instead
> of the argument to AARCH64_EXTRA_TUNING_OPTION.
> * config/aarch64/aarch64.c: Remove the last argument to
> AARCH64_EXTRA_TUNING_OPTION..
Watch out for the extra . on the end of this ChangeLog line..
Thanks,
James
>
next prev parent reply other threads:[~2015-08-19 16:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 16:03 Andrew Pinski
2015-08-19 16:14 ` James Greenhalgh [this message]
2015-08-22 10:36 ` Andrew Pinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150819160834.GB37938@e107456-lin.cambridge.arm.com \
--to=james.greenhalgh@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).