Re: [PATCH] remove more useless typedefs

[Trevor Saunders <tbsaunde@tbsaunde.org>]

On Wed, Aug 19, 2015 at 01:11:04PM -0400, David Malcolm wrote:
> On Wed, 2015-08-19 at 11:50 -0400, tbsaunde+gcc@tbsaunde.org wrote:
> > From: tbsaunde <tbsaunde@138bc75d-0d04-0410-961f-82ee72b054a4>
> > 
> > Hi,
> > 
> > more typedef cleanup.
> > 
> > bootstrapped + regtested on x86_64-linux-gnu, commited since preapproved
> >  by richi.
> 
> [...]
> 
> > diff --git a/gcc/ChangeLog b/gcc/ChangeLog
> > index db23a0f..32421c5 100644
> > --- a/gcc/ChangeLog
> > +++ b/gcc/ChangeLog
> > @@ -1,3 +1,15 @@
> > +2015-08-18  Trevor Saunders  <tbsaunde@tbsaunde.org>
> > +
> > +	* bb-reorder.c, cfgloop.h, collect2.c, combine.c, dse.c,
> > +	dwarf2cfi.c, gcse-common.h, genopinit.c, ggc-page.c, machmode.h,
> > +	mcf.c, modulo-sched.c, omp-low.c, read-rtl.c, sched-rgn.c,
> > +	signop.h, tree-call-cdce.c, tree-dfa.c, tree-diagnostic.c,
> > +	tree-inline.h, tree-scalar-evolution.c, tree-ssa-address.c,
> > +	tree-ssa-loop-niter.c, tree-ssa-loop.h, tree-ssa-pre.c,
> > +	tree-ssa-reassoc.c, tree-ssa-sccvn.h, tree-ssa-structalias.c,
> > +	tree-ssa-uninit.c, tree-ssa.h, tree-vect-loop-manip.c,
> > +	tree-vectorizer.h, tree-vrp.c, var-tracking.c: Remove useless
> > +
> 
> FWIW, it looks like this ChangeLog entry is missing the trailing word
> "typedefs".
> 
> > diff --git a/gcc/c-family/ChangeLog b/gcc/c-family/ChangeLog
> > index 7a25c39..eb717a0 100644
> > --- a/gcc/c-family/ChangeLog
> > +++ b/gcc/c-family/ChangeLog
> > @@ -1,3 +1,8 @@
> > +2015-08-18  Trevor Saunders  <tbsaunde@tbsaunde.org>
> > +
> > +	* c-ada-spec.h, c-common.c, c-common.h, c-format.c, c-format.h,
> > +	c-objc.h, c-ppoutput.c, c-pragma.c, c-pragma.h: Remove useless
> > +
> 
> Likewise.
> 
> 
> > diff --git a/gcc/c/ChangeLog b/gcc/c/ChangeLog
> > index 275d787..1536b1b 100644
> > --- a/gcc/c/ChangeLog
> > +++ b/gcc/c/ChangeLog
> > @@ -1,3 +1,7 @@
> > +2015-08-18  Trevor Saunders  <tbsaunde@tbsaunde.org>
> > +
> > +	* c-aux-info.c, c-parser.c, c-tree.h: Remove useless typedefs.
> > +
> 
> ...whereas this one looks correct.
> 
> 
> > diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog
> > index 3a63875..9cbaf6c 100644
> > --- a/gcc/fortran/ChangeLog
> > +++ b/gcc/fortran/ChangeLog
> > @@ -1,3 +1,8 @@
> > +2015-08-18  Trevor Saunders  <tbsaunde@tbsaunde.org>
> > +
> > +	* dependency.c, dependency.h, gfortran.h, io.c, module.c,
> > +	parse.h, resolve.c, trans-types.h, trans.h: remove useless
> > +
> 
> ...and this one looks wrong.
> 
> 
> Looking at:
> https://gcc.gnu.org/viewcvs/gcc?limit_changes=0&view=revision&revision=227001
> 
> it looks like the copy of the ChangeLog in the commit message contains
> the missing words (albeit without indentation), but the actual ChangeLog
> files don't.

oops! I think what happened is vim didn't autoindent for some reason and
I didn't notice (I was tired while writing the logs) then my script to
apply change logs from commit messages was buggy and just dropped those
lines :(

btw I should get around to putting a better version of that script in
contrib/ unless someone else has an actually good script to update
ChangeLog files from commit messages.

I guess we could also have a commit hook that checks commit and
ChangeLog format.

Trev

> 
> Dave
>