From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10009 invoked by alias); 19 Aug 2015 19:13:36 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 6110 invoked by uid 89); 19 Aug 2015 19:13:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.9 required=5.0 tests=AWL,BAYES_99,BAYES_999,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: paperclip.tbsaunde.org Received: from tbsaunde.org (HELO paperclip.tbsaunde.org) (66.228.47.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Aug 2015 19:13:34 +0000 Received: from tsaunders-iceball.corp.tor1.mozilla.com (unknown [66.207.208.102]) by paperclip.tbsaunde.org (Postfix) with ESMTPSA id 4C99BC06A; Wed, 19 Aug 2015 19:13:32 +0000 (UTC) Date: Wed, 19 Aug 2015 19:33:00 -0000 From: Trevor Saunders To: David Malcolm Cc: tbsaunde+gcc@tbsaunde.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] remove more useless typedefs Message-ID: <20150819191239.GA9676@tsaunders-iceball.corp.tor1.mozilla.com> References: <1439999400-11671-1-git-send-email-tbsaunde+gcc@tbsaunde.org> <1440004264.18943.15.camel@surprise> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440004264.18943.15.camel@surprise> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-08/txt/msg01128.txt.bz2 On Wed, Aug 19, 2015 at 01:11:04PM -0400, David Malcolm wrote: > On Wed, 2015-08-19 at 11:50 -0400, tbsaunde+gcc@tbsaunde.org wrote: > > From: tbsaunde > > > > Hi, > > > > more typedef cleanup. > > > > bootstrapped + regtested on x86_64-linux-gnu, commited since preapproved > > by richi. > > [...] > > > diff --git a/gcc/ChangeLog b/gcc/ChangeLog > > index db23a0f..32421c5 100644 > > --- a/gcc/ChangeLog > > +++ b/gcc/ChangeLog > > @@ -1,3 +1,15 @@ > > +2015-08-18 Trevor Saunders > > + > > + * bb-reorder.c, cfgloop.h, collect2.c, combine.c, dse.c, > > + dwarf2cfi.c, gcse-common.h, genopinit.c, ggc-page.c, machmode.h, > > + mcf.c, modulo-sched.c, omp-low.c, read-rtl.c, sched-rgn.c, > > + signop.h, tree-call-cdce.c, tree-dfa.c, tree-diagnostic.c, > > + tree-inline.h, tree-scalar-evolution.c, tree-ssa-address.c, > > + tree-ssa-loop-niter.c, tree-ssa-loop.h, tree-ssa-pre.c, > > + tree-ssa-reassoc.c, tree-ssa-sccvn.h, tree-ssa-structalias.c, > > + tree-ssa-uninit.c, tree-ssa.h, tree-vect-loop-manip.c, > > + tree-vectorizer.h, tree-vrp.c, var-tracking.c: Remove useless > > + > > FWIW, it looks like this ChangeLog entry is missing the trailing word > "typedefs". > > > diff --git a/gcc/c-family/ChangeLog b/gcc/c-family/ChangeLog > > index 7a25c39..eb717a0 100644 > > --- a/gcc/c-family/ChangeLog > > +++ b/gcc/c-family/ChangeLog > > @@ -1,3 +1,8 @@ > > +2015-08-18 Trevor Saunders > > + > > + * c-ada-spec.h, c-common.c, c-common.h, c-format.c, c-format.h, > > + c-objc.h, c-ppoutput.c, c-pragma.c, c-pragma.h: Remove useless > > + > > Likewise. > > > > diff --git a/gcc/c/ChangeLog b/gcc/c/ChangeLog > > index 275d787..1536b1b 100644 > > --- a/gcc/c/ChangeLog > > +++ b/gcc/c/ChangeLog > > @@ -1,3 +1,7 @@ > > +2015-08-18 Trevor Saunders > > + > > + * c-aux-info.c, c-parser.c, c-tree.h: Remove useless typedefs. > > + > > ...whereas this one looks correct. > > > > diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog > > index 3a63875..9cbaf6c 100644 > > --- a/gcc/fortran/ChangeLog > > +++ b/gcc/fortran/ChangeLog > > @@ -1,3 +1,8 @@ > > +2015-08-18 Trevor Saunders > > + > > + * dependency.c, dependency.h, gfortran.h, io.c, module.c, > > + parse.h, resolve.c, trans-types.h, trans.h: remove useless > > + > > ...and this one looks wrong. > > > Looking at: > https://gcc.gnu.org/viewcvs/gcc?limit_changes=0&view=revision&revision=227001 > > it looks like the copy of the ChangeLog in the commit message contains > the missing words (albeit without indentation), but the actual ChangeLog > files don't. oops! I think what happened is vim didn't autoindent for some reason and I didn't notice (I was tired while writing the logs) then my script to apply change logs from commit messages was buggy and just dropped those lines :( btw I should get around to putting a better version of that script in contrib/ unless someone else has an actually good script to update ChangeLog files from commit messages. I guess we could also have a commit hook that checks commit and ChangeLog format. Trev > > Dave >