From: Marek Polacek <polacek@redhat.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>, Jeff Law <law@redhat.com>,
Richard Biener <rguenther@suse.de>
Subject: [PATCH] Fix libgo breakage (PR tree-optimization/67284)
Date: Fri, 21 Aug 2015 11:00:00 -0000 [thread overview]
Message-ID: <20150821105233.GJ2729@redhat.com> (raw)
This fixes the libgo breakage. Seems I really should have removed the
edge after we split the block with null dereference after __builtin_trap
statement so that it's unreachable.
Bootstrapped/regtested on x86_64-linux + ppc64-linux + bootstrapped on
aarch64-linux, ok for trunk?
2015-08-21 Marek Polacek <polacek@redhat.com>
PR tree-optimization/67284
* gimple-ssa-isolate-paths.c (insert_trap): Remove the edge after
we split a block.
diff --git gcc/gimple-ssa-isolate-paths.c gcc/gimple-ssa-isolate-paths.c
index ca2322d..5ac61d3 100644
--- gcc/gimple-ssa-isolate-paths.c
+++ gcc/gimple-ssa-isolate-paths.c
@@ -115,7 +115,8 @@ insert_trap (gimple_stmt_iterator *si_p, tree op)
else
gsi_insert_before (si_p, seq, GSI_NEW_STMT);
- split_block (gimple_bb (new_stmt), new_stmt);
+ edge e = split_block (gimple_bb (new_stmt), new_stmt);
+ remove_edge (e);
*si_p = gsi_for_stmt (stmt);
}
Marek
next reply other threads:[~2015-08-21 10:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-21 11:00 Marek Polacek [this message]
2015-08-21 12:07 ` Richard Biener
2015-08-21 12:50 ` Marek Polacek
2015-08-21 13:40 ` Richard Biener
2015-08-21 14:43 ` Marek Polacek
2015-08-21 15:05 ` Jeff Law
2015-08-21 15:37 ` Jeff Law
2015-08-21 16:23 ` Richard Biener
2015-08-21 16:30 ` Richard Biener
2015-08-21 16:52 ` Marek Polacek
2015-08-21 17:31 ` Richard Biener
2015-08-24 9:17 ` Jakub Jelinek
2015-08-24 9:23 ` Marek Polacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150821105233.GJ2729@redhat.com \
--to=polacek@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).