From: Jakub Jelinek <jakub@redhat.com>
To: Maxim Blumental <bvmaks@gmail.com>
Cc: David Malcolm <dmalcolm@redhat.com>,
Kirill Yukhin <kirill.yukhin@gmail.com>,
Ilya Verbin <iverbin@gmail.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: Fwd: [PATCH 3/4] Add libgomp plugin for Intel MIC
Date: Mon, 24 Aug 2015 08:51:00 -0000 [thread overview]
Message-ID: <20150824084503.GD9425@tucnak.redhat.com> (raw)
In-Reply-To: <CACy_Q+yYnrFw4U_Lt7RQ_NUB=xPZF+xrZvOyUyKpjNMqUajt=g@mail.gmail.com>
On Thu, Aug 06, 2015 at 05:34:56PM +0300, Maxim Blumental wrote:
> Applied the idea with python script alternative. Review, please.
> 2015-07-28 Maxim Blumenthal <maxim.blumenthal@intel.com>
>
> * configure.ac: Add a check for xxd or python presence when the target
> is intelmic or intelmicemul.
> * configure: Regenerate.
> * liboffloadmic/plugin/Makefile.am: Add a condition into
> make_target_image.h generating code. This condition performs an
> action with either xxd or a special python script during the
> generating.
> * liboffloadmic/plugin/xxd.py: New file.
> * liboffloadmic/plugin/Makefile.in: Regenerate.
I still don't like this, there should be no `which ...` uses in the
Makefile.
Instead, use AC_CHECK_PROG/AC_CHECK_PROGS in configure.ac, for python
perhaps search for python python2 python3 or what is common in the python
land. And prepare the command line to use in the Makefile.am in configure
too, then AC_SUBST it and use the variable in there (and the variable will
use $@ etc.).
Jakub
next prev parent reply other threads:[~2015-08-24 8:45 UTC|newest]
Thread overview: 111+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 17:16 [PATCH 0/4] OpenMP 4.0 offloading to " Ilya Verbin
2014-10-21 17:20 ` [PATCH 1/4] Add mkoffload for " Ilya Verbin
2014-10-21 21:58 ` Joseph S. Myers
2014-10-21 22:31 ` Ilya Verbin
2014-10-22 7:59 ` Jakub Jelinek
2014-10-22 8:27 ` Jakub Jelinek
2014-10-22 18:57 ` Ilya Verbin
2014-11-03 17:36 ` [gomp4] Mark fopenacc as LTO option Tom de Vries
2015-01-23 15:44 ` [committed][PR64707] Make fopenmp an " Tom de Vries
2015-01-23 15:53 ` [committed][PR64672] Make fopenacc " Tom de Vries
2014-11-06 18:02 ` [PATCH 1/4] Add mkoffload for Intel MIC Jakub Jelinek
2014-12-22 11:25 ` OMP builtins in offloading (was: [PATCH 1/4] Add mkoffload for Intel MIC) Thomas Schwinge
2014-12-22 11:28 ` Jakub Jelinek
2014-12-26 15:49 ` Ilya Verbin
2015-01-08 15:42 ` Thomas Schwinge
2015-01-08 15:49 ` Jakub Jelinek
2015-01-08 16:32 ` Ilya Verbin
2015-01-08 16:39 ` Jakub Jelinek
2015-01-09 10:40 ` Richard Biener
2015-01-09 10:45 ` Jakub Jelinek
2015-02-16 18:58 ` Ilya Verbin
2021-08-04 9:46 ` OMP builtins in offloading Thomas Schwinge
2014-12-22 11:27 ` [PATCH 1/4] Add mkoffload for Intel MIC Thomas Schwinge
2014-12-22 11:48 ` Jakub Jelinek
2015-01-08 14:59 ` Thomas Schwinge
2015-01-08 15:02 ` H.J. Lu
2015-01-08 16:21 ` Thomas Schwinge
2015-08-04 11:20 ` Use gcc/coretypes.h:enum offload_abi in mkoffloads (was: [PATCH 1/4] Add mkoffload for Intel MIC) Thomas Schwinge
2015-09-28 8:26 ` Use gcc/coretypes.h:enum offload_abi in mkoffloads Thomas Schwinge
2015-09-28 11:28 ` Bernd Schmidt
2015-09-30 10:05 ` Thomas Schwinge
2015-02-18 11:48 ` [PATCH 1/4] Add mkoffload for Intel MIC Thomas Schwinge
2015-02-18 11:56 ` Ilya Verbin
2015-02-18 12:23 ` [PATCH] Use automatic dependencies for mkoffload.o Jakub Jelinek
2015-02-18 13:10 ` Richard Biener
2015-02-18 12:01 ` [PATCH 1/4] Add mkoffload for Intel MIC Jakub Jelinek
2015-09-28 9:39 ` Thomas Schwinge
2015-09-28 11:26 ` Bernd Schmidt
2015-09-28 11:27 ` Bernd Schmidt
2015-09-28 12:00 ` Ilya Verbin
2015-09-28 12:05 ` Bernd Schmidt
2015-09-28 12:33 ` Jakub Jelinek
2015-09-28 12:33 ` Bernd Schmidt
2015-09-29 11:24 ` Richard Biener
2015-09-29 12:11 ` Bernd Schmidt
2015-09-30 17:55 ` Refactor intelmic-mkoffload.c argv building to use obstacks (was: [PATCH 1/4] Add mkoffload for Intel MIC) Thomas Schwinge
2015-03-06 13:55 ` [PATCH] Fix intelmic-mkoffload " Ilya Verbin
2015-03-09 14:49 ` Jakub Jelinek
2014-10-21 17:24 ` [PATCH 2/4] Add liboffloadmic Ilya Verbin
2014-10-22 8:55 ` Jakub Jelinek
2014-10-22 17:13 ` Joseph S. Myers
2014-10-22 19:31 ` Ilya Verbin
2014-10-29 16:31 ` Ilya Verbin
2014-11-06 18:21 ` Jakub Jelinek
2014-11-12 10:52 ` Jakub Jelinek
2014-11-12 13:29 ` Ilya Verbin
2014-12-12 10:46 ` Thomas Schwinge
2015-02-04 17:45 ` Ilya Verbin
2015-02-04 17:46 ` Jakub Jelinek
2015-07-09 10:00 ` Thomas Schwinge
2015-07-13 14:31 ` Ilya Verbin
2014-10-21 17:28 ` [PATCH 3/4] Add libgomp plugin for Intel MIC Ilya Verbin
2014-10-22 9:47 ` Jakub Jelinek
2014-10-23 16:00 ` Ilya Verbin
2014-10-24 14:57 ` Jakub Jelinek
2014-10-24 15:12 ` Ilya Verbin
2014-10-24 15:19 ` Jakub Jelinek
2014-10-27 14:24 ` Ilya Verbin
2014-11-06 18:25 ` Jakub Jelinek
2014-11-10 14:32 ` Ilya Verbin
2014-11-11 7:07 ` Jakub Jelinek
2014-12-12 9:42 ` Thomas Schwinge
2015-01-08 14:48 ` Thomas Schwinge
2015-07-08 14:16 ` Thomas Schwinge
2015-07-08 15:14 ` Ilya Verbin
2015-07-08 15:52 ` Thomas Schwinge
2015-07-23 19:05 ` Ilya Verbin
2015-07-24 8:06 ` Jakub Jelinek
2015-07-24 14:27 ` David Malcolm
2015-07-28 15:51 ` Maxim Blumental
2015-08-03 10:24 ` Maxim Blumental
2015-08-04 17:40 ` David Malcolm
2015-08-06 14:35 ` Fwd: " Maxim Blumental
2015-08-11 12:27 ` Maxim Blumental
2015-08-24 8:51 ` Jakub Jelinek [this message]
2014-10-30 12:45 ` [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing Ilya Verbin
2014-11-06 17:55 ` Jakub Jelinek
2014-11-10 14:51 ` Ilya Verbin
2014-11-11 7:10 ` Jakub Jelinek
2014-11-12 9:18 ` Jakub Jelinek
2014-12-17 22:53 ` Thomas Schwinge
2014-12-18 10:46 ` Jakub Jelinek
2014-12-22 16:37 ` Thomas Schwinge
2014-12-18 15:56 ` Thomas Schwinge
2014-12-18 17:43 ` Ilya Verbin
2014-12-18 17:56 ` Jakub Jelinek
2014-12-22 11:49 ` Thomas Schwinge
2014-12-22 12:50 ` Jakub Jelinek
2015-01-15 19:21 ` Ilya Verbin
2015-01-15 19:25 ` Jakub Jelinek
2015-01-28 17:28 ` Ilya Verbin
2015-01-28 17:42 ` Jakub Jelinek
2015-01-28 17:51 ` Ilya Verbin
2015-02-02 14:03 ` Ilya Verbin
2014-12-26 20:53 ` Ilya Verbin
2015-01-08 16:03 ` Thomas Schwinge
2016-03-13 19:10 ` Thomas Schwinge
2014-12-22 12:08 ` [PATCH 0/4] OpenMP 4.0 offloading to Intel MIC Thomas Schwinge
2015-10-22 18:28 ` Ilya Verbin
2015-10-23 8:10 ` Jakub Jelinek
2015-10-26 14:39 ` Ilya Verbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150824084503.GD9425@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=bvmaks@gmail.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=iverbin@gmail.com \
--cc=kirill.yukhin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).