From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39508 invoked by alias); 24 Aug 2015 09:07:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 39498 invoked by uid 89); 24 Aug 2015 09:07:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 24 Aug 2015 09:07:52 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 800B88CF51; Mon, 24 Aug 2015 09:07:51 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-26.ams2.redhat.com [10.36.116.26]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7O97n7a015223 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 24 Aug 2015 05:07:50 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id t7O97hYX014400; Mon, 24 Aug 2015 11:07:43 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id t7O97fQW014399; Mon, 24 Aug 2015 11:07:41 +0200 Date: Mon, 24 Aug 2015 09:17:00 -0000 From: Jakub Jelinek To: Richard Biener Cc: Marek Polacek , Jeff Law , Richard Biener , GCC Patches Subject: Re: [PATCH] Fix libgo breakage (PR tree-optimization/67284) Message-ID: <20150824090741.GF9425@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20150821105233.GJ2729@redhat.com> <20150821124922.GK2729@redhat.com> <20150821144122.GL2729@redhat.com> <55D73F3A.5080901@redhat.com> <20150821164215.GM2729@redhat.com> <7C836746-260C-4767-B17F-CA2181E771A5@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7C836746-260C-4767-B17F-CA2181E771A5@suse.de> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg01387.txt.bz2 On Fri, Aug 21, 2015 at 07:22:24PM +0200, Richard Biener wrote: > On August 21, 2015 6:42:15 PM GMT+02:00, Marek Polacek wrote: > >On Fri, Aug 21, 2015 at 06:23:09PM +0200, Richard Biener wrote: > >> >> Yes, but gimple_call_noreturn_p is false on __builtin_trap. > >That's > >> >quite > >> >> confusing... but flags_from_decl_or_type really returns 0 for > >> >__builtin_trap. > >> >Well, if that's intentional (and offhand I have no idea if it is), > >then > >> > > >> >you could emit a __builtin_trap followed by a __builtin_unreachable. > >> > >> But maybe go is non-call-exceptions and that makes a difference? > > > >I suppose that's the case. In Makefile.am I see > >AM_CFLAGS = -fexceptions -fnon-call-exceptions -fplan9-extensions > >But I'm not clear on how this could make a difference wrt whether > >__builtin_trap is volatile (thus ECF_NORETURN). > > Not sure either. Needs to be investigated. BTW, built-in trap is also nothrow AFAIR. I think the bug is in the Go FE which incorrectly doesn't set TREE_THIS_VOLATILE on the __builtin_trap decl. Jakub