From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3725 invoked by alias); 27 Aug 2015 12:26:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 3702 invoked by uid 89); 27 Aug 2015 12:26:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 27 Aug 2015 12:26:09 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 61C798E3FB; Thu, 27 Aug 2015 12:26:08 +0000 (UTC) Received: from localhost (ovpn-116-95.ams2.redhat.com [10.36.116.95]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7RCQ7Gr010871; Thu, 27 Aug 2015 08:26:07 -0400 Date: Thu, 27 Aug 2015 12:32:00 -0000 From: Jonathan Wakely To: John Marino Cc: gcc-patches , libstdc++@gcc.gnu.org Subject: Re: [patch][libstdc++] Provide nearly complete locale support for DragonFly Message-ID: <20150827122606.GR2631@redhat.com> References: <55BB9D15.8080202@marino.st> <55CC9811.3080208@marino.st> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <55CC9811.3080208@marino.st> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-08/txt/msg01688.txt.bz2 On 13/08/15 15:13 +0200, John Marino wrote: >On 7/31/2015 6:06 PM, John Marino wrote: >> So far, DragonFly only handles the C/POSIX locale through the "generic" >> locale support files, similar to FreeBSD and Darwin. The following >> patchset enables nearly complete support for named locales. The except >> is for std:messages which requires gettext support in libc which is not >> present in any *BSD. For that category, I have left generic support in >> place at Jonathan's recommendation. >> >> The support was made by talking the GNU version and adapting it to work >> on DragonFly. >> >> Testing has shown these patches to be working. A "before" test results: >> https://gcc.gnu.org/ml/gcc-testresults/2015-07/msg01678.html >> PASS: 9883 >> FAIL: 89 >> XSUCC: 1 >> XFAIL: 66 >> UNSUP: 465 >> The most recent test: >> https://gcc.gnu.org/ml/gcc-testresults/2015-07/msg03024.html >> PASS: 10074 >> FAIL: 32 >> XFAIL: 68 >> UNSUP: 401 >> >> For full disclosure, a number of improvements were made to the OS in the >> area of locales, such as DragonFly being the first BSD to acquire full >> collation support. >> >> Most of the remaining failures are due to differences in locale >> definitions between linux and DragonFly (DragonFly now uses CLDR POSIX >> definitions, v2.0.1 currently) >> >> Attachments: >> 1. combined diff >> 2. diff between gnu and dragonfly version (FYI) >> 3. Suggested Changelog entry >> >> This work should be highly interesting for FreeBSD and perhaps darwin as >> well. FreeBSD may be able to switch to it directly without any required >> modifications, but of course that must be tested. >> >> There is no risk to approving this patchset because it affects only >> DragonFly. Please consider approving this for incorporating into trunk >> (also recall that my FSF copyright assignment is filed and in order.) >> N.B. please CC the libstdc++ list on all libstdc++ patches. The tests on DragonFly look excellent now, nice work. > >I'd like to ping the original post >(https://gcc.gnu.org/ml/gcc-patches/2015-07/msg02678.html ) >and also provide a 2-line revision of the patch set. > >The first line adds "#include " to bits/c++locale.h which is >needed for the locale_t type definition. > >The second change adds "#define _GLIBCXX_USE_C99 1" to dragonfly's >os_defines.h. We copied FreeBSD's configuration, but FreeBSD doesn't >yet support C99 so it wasn't set there. It fixes several regressions we >found after using GCC a bit. I think that should probably be defined on FreeBSD too now, so that the _GLIBCXX_USE_C99_DYNAMIC checks come into effect. >How does this attached patchset look? >I had to add one line to the suggested Changelog entry for os_defines.h Committed to trunk with only minor changes to remove some trailing whitespace in config/os/bsd/dragonfly/ctype_configure_char.cc and to capitalize a couple of ChangeLog lines. Thanks for the ongoing improvements to DragonFly support.