From: James Greenhalgh <james.greenhalgh@arm.com>
To: Kyrill Tkachov <kyrylo.tkachov@arm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Marcus Shawcroft <Marcus.Shawcroft@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: [PATCH][AArch64] Fix FAIL: gcc.target/aarch64/target_attr_crypto_ice_1.c (internal compiler error)
Date: Tue, 01 Sep 2015 09:26:00 -0000 [thread overview]
Message-ID: <20150901092630.GB28861@arm.com> (raw)
In-Reply-To: <55D4878F.4040803@arm.com>
On Wed, Aug 19, 2015 at 02:41:35PM +0100, Kyrill Tkachov wrote:
> Hi all,
>
> This fixes the ICE exposed by Alexandre's patch (https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00873.html)
> The solution I came up with is to re-layout the parameter decls not during expansion time (when RTL has already
> been allocated to SSA names) but in TARGET_SET_CURRENT_FUNCTION which is called much earlier before that and is
> used when setting cfun. This way we reach expand with the proper vector modes registered for the param decls
> and all seems to work ok.
>
> The aarch64-builtins.c workaround that I initially introduced in https://gcc.gnu.org/ml/gcc-patches/2015-07/msg02012.html
> are partially reverted (at least the re-laying out parts).
>
> The patch fixes the target_attr_crypto_ice_1.c ICE but I'd like to add a second derived testcase that
> tests a different expansion path and it has proved useful in writing this patch.
>
> Bootstrapped and tested on aarch64.
>
> Ok for trunk?
OK.
Thanks,
James
> 2015-08-19 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
>
> * config/aarch64/aarch64.c (aarch64_set_current_function):
> Re-layout any vector parameters have non-simd layout.
> * config/aarch64/aarch64-builtins.c (aarch64_relayout_simd_param):
> Delete.
> (aarch64_simd_expand_args): Delete call to the above.
>
> 2015-08-19 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
>
> * gcc.target/aarch64/target_attr_crypto_ice_2.c: New test.
prev parent reply other threads:[~2015-09-01 9:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 13:43 Kyrill Tkachov
2015-09-01 8:39 ` Kyrill Tkachov
2015-09-01 9:26 ` James Greenhalgh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150901092630.GB28861@arm.com \
--to=james.greenhalgh@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).