From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102455 invoked by alias); 1 Sep 2015 09:26:36 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 102437 invoked by uid 89); 1 Sep 2015 09:26:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: cam-smtp0.cambridge.arm.com Received: from fw-tnat.cambridge.arm.com (HELO cam-smtp0.cambridge.arm.com) (217.140.96.140) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 01 Sep 2015 09:26:34 +0000 Received: from arm.com (e107456-lin.cambridge.arm.com [10.2.207.14]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id t819QUgE018616; Tue, 1 Sep 2015 10:26:30 +0100 Date: Tue, 01 Sep 2015 09:26:00 -0000 From: James Greenhalgh To: Kyrill Tkachov Cc: GCC Patches , Marcus Shawcroft , Richard Earnshaw Subject: Re: [PATCH][AArch64] Fix FAIL: gcc.target/aarch64/target_attr_crypto_ice_1.c (internal compiler error) Message-ID: <20150901092630.GB28861@arm.com> References: <55D4878F.4040803@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55D4878F.4040803@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00018.txt.bz2 On Wed, Aug 19, 2015 at 02:41:35PM +0100, Kyrill Tkachov wrote: > Hi all, > > This fixes the ICE exposed by Alexandre's patch (https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00873.html) > The solution I came up with is to re-layout the parameter decls not during expansion time (when RTL has already > been allocated to SSA names) but in TARGET_SET_CURRENT_FUNCTION which is called much earlier before that and is > used when setting cfun. This way we reach expand with the proper vector modes registered for the param decls > and all seems to work ok. > > The aarch64-builtins.c workaround that I initially introduced in https://gcc.gnu.org/ml/gcc-patches/2015-07/msg02012.html > are partially reverted (at least the re-laying out parts). > > The patch fixes the target_attr_crypto_ice_1.c ICE but I'd like to add a second derived testcase that > tests a different expansion path and it has proved useful in writing this patch. > > Bootstrapped and tested on aarch64. > > Ok for trunk? OK. Thanks, James > 2015-08-19 Kyrylo Tkachov > > * config/aarch64/aarch64.c (aarch64_set_current_function): > Re-layout any vector parameters have non-simd layout. > * config/aarch64/aarch64-builtins.c (aarch64_relayout_simd_param): > Delete. > (aarch64_simd_expand_args): Delete call to the above. > > 2015-08-19 Kyrylo Tkachov > > * gcc.target/aarch64/target_attr_crypto_ice_2.c: New test.