From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15186 invoked by alias); 1 Sep 2015 10:26:28 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 15175 invoked by uid 89); 1 Sep 2015 10:26:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 01 Sep 2015 10:26:27 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id E32F2C18F738; Tue, 1 Sep 2015 10:26:25 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-44.ams2.redhat.com [10.36.116.44]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t81AQOTV001066 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 1 Sep 2015 06:26:25 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id t81AQMd5026275; Tue, 1 Sep 2015 12:26:23 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id t81AQLxL026274; Tue, 1 Sep 2015 12:26:21 +0200 Date: Tue, 01 Sep 2015 10:26:00 -0000 From: Jakub Jelinek To: Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix TERed insn locations Message-ID: <20150901102621.GO1847@tucnak.redhat.com> Reply-To: Jakub Jelinek References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00024.txt.bz2 On Tue, Sep 01, 2015 at 12:09:48PM +0200, Richard Biener wrote: > > So I finally got around to dig into why some testcases I inspected for > early LTO debug (and some existing guality FAILs) happen. They happen > because we screw up locations of insns coming from TERed SSA defs > which end up using the TERed-into stmt location. So final re-building > the BLOCK tree ends up with no stmts in those BLOCKs and thus we > don't get any location annotations (even if the var location notes > are there). > > It looks like expand_expr_real_2 might have been designed to use > ops.location but in fact it only uses that when building other trees. For > singles we already adjust curr_insn_location, so the following does > that for all defs. > > This seems to explain the guality degradation over the years (we > just got better in coalescing / TERing...). > > In my dev tree this fixes all non-LTO, non-VLA guality FAILs, now > bootstrapping and testing on x86_64-unknown-linux-gnu. > > Note this patch can cause some extra jumping around between locations > in gdb - but that's expected I guess. It probably also causes some > debug-info growth. > > Ok for trunk if testing succeeds? Ok to backport? I'd say ok for trunk, wait some time before backport. > 2015-09-01 Richard Biener > > * expr.c (expand_expr_real_1): For expanding TERed defs > set the current location to that of the def if not UNKNOWN. Jakub