From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95759 invoked by alias); 2 Sep 2015 13:53:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 95733 invoked by uid 89); 2 Sep 2015 13:53:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: cam-smtp0.cambridge.arm.com Received: from fw-tnat.cambridge.arm.com (HELO cam-smtp0.cambridge.arm.com) (217.140.96.140) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 02 Sep 2015 13:53:20 +0000 Received: from arm.com (e107456-lin.cambridge.arm.com [10.2.207.14]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id t82DrHML001761; Wed, 2 Sep 2015 14:53:17 +0100 Date: Wed, 02 Sep 2015 13:53:00 -0000 From: James Greenhalgh To: Christophe Lyon Cc: "gcc-patches@gcc.gnu.org" Subject: Re: [AArch64_be] Fix vldX/vstX AdvSIMD intrinsics Message-ID: <20150902135316.GA1990@arm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00159.txt.bz2 On Wed, Sep 02, 2015 at 02:18:03PM +0100, Christophe Lyon wrote: > Hi, > > The aarch64_vldX/aarch64_vstX expanders used for the vldX/vstX AdvSIMD > intrisics in Q mode called vec_load_lanes, witch shuffles the vectors > to match the layout expected by the vectorizer. > > We do not want this to happen when the intrinsics are called directly > by the end-user code. > > This patch fixes this, by calling gen_aarch64_simd_ldX/gen_aarch64_simd_stX. > > With this patch, the following tests now pass in advsimd-intrinsics > (target aarch64_be): > vldX_lane.c, vtrn, vuzp, vzip > as well as aarch64/vldN_1.c and aarch64/vstN_1.c > > It fixes PR 59810, 63652, 63653. Great! > > No regression, and tested on aarch64 and aarch64_be using the Foundation Model. > > OK for trunk? OK. Thanks, James > 2015-09-02 Christophe Lyon > > PR target/59810 > PR target/63652 > PR target/63653 > * config/aarch64/aarch64-simd.md > (aarch64_ld): Call > gen_aarch64_simd_ld. > (aarch64_st): Call > gen_aarch64_simd_st.