From: Jonathan Wakely <jwakely@redhat.com>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: libstdc++@gcc.gnu.org, GCC Patches <gcc-patches@gcc.gnu.org>,
Alexander Potapenko <glider@google.com>,
Kostya Serebryany <kcc@google.com>
Subject: Re: [Patch, libstdc++] Fix data races in basic_string implementation
Date: Wed, 02 Sep 2015 14:05:00 -0000 [thread overview]
Message-ID: <20150902140531.GK2631@redhat.com> (raw)
In-Reply-To: <CACT4Y+YG-T5jAh+6p4o0umZRSOpz0OZE3bdMT7nFWs3j34yw3g@mail.gmail.com>
On 02/09/15 15:49 +0200, Dmitry Vyukov wrote:
>On Wed, Sep 2, 2015 at 12:58 PM, Marc Glisse <marc.glisse@inria.fr> wrote:
>> On Tue, 1 Sep 2015, Dmitry Vyukov wrote:
>>
>>> The refcounted basic_string implementation contains several data races
>>> on _M_refcount:
>>
>>
>> There are several bug reports about races in basic_string in bugzilla (some
>> might even have been closed as wontfix because of the new implementation).
>> Does this also fix some of them?
>
>I've tried to search for "basic_string race" with all statuses:
>https://gcc.gnu.org/bugzilla/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=SUSPENDED&bug_status=WAITING&bug_status=REOPENED&bug_status=RESOLVED&bug_status=VERIFIED&bug_status=CLOSED&cf_known_to_fail_type=allwords&cf_known_to_work_type=allwords&component=libstdc%2B%2B&list_id=125385&query_format=advanced&short_desc=basic_string%20race&short_desc_type=allwordssubstr
>
>But it does not yield anything interesting. What bugs can I reference?
There's https://gcc.gnu.org/bugzilla/show_bug.cgi?id=21334 but I don't
think this fixes it. That's a race condition in the logic, not a
formal data race due to non-atomic operations like the problem being
fixed here.
prev parent reply other threads:[~2015-09-02 14:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 12:52 Dmitry Vyukov
2015-09-01 14:27 ` Jonathan Wakely
2015-09-01 14:56 ` Dmitry Vyukov
2015-09-01 15:08 ` Jonathan Wakely
2015-09-01 15:42 ` Dmitry Vyukov
2015-09-02 13:17 ` Jonathan Wakely
2015-09-02 14:02 ` Dmitry Vyukov
2015-09-02 14:08 ` Jonathan Wakely
2015-09-02 14:39 ` Dmitry Vyukov
2015-09-02 10:58 ` Marc Glisse
2015-09-02 13:50 ` Dmitry Vyukov
2015-09-02 14:05 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150902140531.GK2631@redhat.com \
--to=jwakely@redhat.com \
--cc=dvyukov@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=glider@google.com \
--cc=kcc@google.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).