From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62636 invoked by alias); 3 Sep 2015 15:53:52 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 62621 invoked by uid 89); 3 Sep 2015 15:53:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RDNS_DYNAMIC,TVD_RCVD_IP autolearn=no version=3.3.2 X-HELO: brightrain.aerifal.cx Received: from 216-12-86-13.cv.mvl.ntelos.net (HELO brightrain.aerifal.cx) (216.12.86.13) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 03 Sep 2015 15:53:50 +0000 Received: from dalias by brightrain.aerifal.cx with local (Exim 3.15 #2) id 1ZXWpd-0007Zm-00; Thu, 03 Sep 2015 15:53:45 +0000 Date: Thu, 03 Sep 2015 15:59:00 -0000 From: Rich Felker To: Joseph Myers Cc: gcc-patches@gcc.gnu.org Subject: Re: Reviving SH FDPIC target Message-ID: <20150903155345.GQ17773@brightrain.aerifal.cx> References: <20150902183650.GA16052@brightrain.aerifal.cx> <20150902210535.GM17773@brightrain.aerifal.cx> <20150903005101.GN17773@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00281.txt.bz2 On Thu, Sep 03, 2015 at 02:58:39PM +0000, Joseph Myers wrote: > On Wed, 2 Sep 2015, Rich Felker wrote: > > > So if __fpscr_values was the only reason for patch 1/3 in the FDPIC > > patchset, I think we can safely drop it. And patch 2/3 was already > > committed, so 3/3, the one I was originally looking at, seems to be > > all we need. It was approved at the time, so I'll proceed with merging > > it with 5.2.0. > > Well, obviously if trying dropping patch 1/3 you need to remove everything > related to use_initial_val (the feature added in patch 1/3) from patch > 3/3. As far as I can tell, the only "use" of use_initial_val is defining the pseudo-instruction in the md file, which causes the code in patch 1/3 to use it. I see no other references to it. As I understand, the breakage from not having it (in the original 4.5-era patch) would be when introducing references to __fpscr_values later, and no longer having the GOT pointer, but that code is gone now. Rich