From: James Greenhalgh <james.greenhalgh@arm.com>
To: Alan Lawrence <alan.lawrence@arm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 12/15][AArch64] Add vcvt(_high)?_f32_f16 intrinsics, with BE RTL fix
Date: Fri, 04 Sep 2015 09:54:00 -0000 [thread overview]
Message-ID: <20150904095000.GA18679@arm.com> (raw)
In-Reply-To: <1440499622-24989-1-git-send-email-alan.lawrence@arm.com>
On Tue, Aug 25, 2015 at 11:47:02AM +0100, Alan Lawrence wrote:
> James Greenhalgh wrote:
> >>
> >> - VAR1 (UNOP, vec_unpacks_hi_, 10, v4sf)
> >> + VAR2 (UNOP, vec_unpacks_hi_, 10, v4sf, v8hf)
> >
> > Should this not use the appropriate "BUILTIN_..." iterator?
>
> Indeed; BUILTIN_VQ_HSF it is.
>
> >> VAR1 (BINOP, float_truncate_hi_, 0, v4sf)
> >> VAR1 (BINOP, float_truncate_hi_, 0, v8hf)
>
> I could also use BUILTIN_VQ_HSF here (these two were added in a previous
> patch, before the VQ_HSF iterator was introduced). However, that goes against
> the principle that we should use the same iterator as the pattern (the
> pattern uses the <Vdbl> attribute of the VDF iterator), so I'm not sure
> whether that would be preferable (i.e. as a separate patch)?
>
> >> - VAR1 (UNOP, float_extend_lo_, 0, v2df)
> >> + VAR2 (UNOP, float_extend_lo_, 0, v2df, v4sf)
> >
> > Likewise.
>
> Similarly, the required iterator does not exist, as float_extend_lo_ is named
> after the <Vwide> attribute of the VDF iterator. The nearest equivalents I can
> see use two VAR1's rather than a VAR2, so I've updated the patch to do that too.
>
> OK with those two changes? (patch attached and bootstrapped+check-gcc on
> aarch64-none-linux-gnu)
OK.
Thanks,
James
next prev parent reply other threads:[~2015-09-04 9:50 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 11:23 [PATCH 0/15][ARM/AArch64] Add support for float16_t vectors (v3) Alan Lawrence
2015-07-28 11:24 ` [PATCH 2/15][ARM] float16x4_t intrinsics in arm_neon.h Alan Lawrence
2015-07-29 15:08 ` Kyrill Tkachov
2015-07-28 11:24 ` [PATCH 3/15][ARM] Add V8HFmode and float16x8_t type Alan Lawrence
2015-07-29 15:12 ` Kyrill Tkachov
2015-07-28 11:24 ` [PATCH 1/15][ARM] Hide existing float16 intrinsics unless we have a scalar __fp16 type Alan Lawrence
2015-07-29 14:53 ` Kyrill Tkachov
2015-08-20 13:45 ` Alan Lawrence
2015-07-28 11:25 ` [PATCH 4/15][ARM] float16x8_t intrinsics in arm_neon.h Alan Lawrence
2015-07-31 9:51 ` Kyrill Tkachov
2015-07-28 11:25 ` [PATCH 5/15][ARM] Remaining intrinsics Alan Lawrence
2015-08-04 11:12 ` Kyrill Tkachov
2015-07-28 11:25 ` [PATCH 6/15][AArch64] Add basic FP16 support Alan Lawrence
2015-07-29 10:09 ` James Greenhalgh
2015-07-28 11:26 ` [PATCH 7/15][ARM/AArch64 Testsuite] Add basic fp16 tests Alan Lawrence
2015-07-29 10:16 ` James Greenhalgh
2015-07-28 11:26 ` [PATCH 10/15][AArch64] Implement vcvt_{,high_}f16_f32 Alan Lawrence
2015-07-29 9:10 ` James Greenhalgh
2015-07-29 9:18 ` Alan Lawrence
2015-07-29 11:39 ` James Greenhalgh
2015-07-28 11:26 ` [PATCH 8/15][AArch64] Add support for float14x{4,8}_t vectors/builtins Alan Lawrence
2015-07-29 10:46 ` James Greenhalgh
2015-07-30 12:26 ` [AArch64] Remove unused VRL2/3/4 iterator values (was: Re: [PATCH 8/15][AArch64] Add support for float14x{4,8}_t vectors/builtins) Alan Lawrence
2015-07-30 13:02 ` James Greenhalgh
2015-07-30 15:13 ` [AArch64] Remove unused VRL2/3/4 iterator values Alan Lawrence
2015-07-30 16:01 ` James Greenhalgh
2015-08-04 11:01 ` [PATCH 8/15][AArch64] Add support for float16x{4,8}_t vectors/builtins Alan Lawrence
2015-08-04 11:13 ` Alan Lawrence
2015-08-17 13:19 ` James Greenhalgh
2015-07-28 11:27 ` [PATCH 14/15][ARM/AArch64 Testsuite]Add test of vcvt{,_high}_{f16_f32,f32_f16} Alan Lawrence
2015-08-25 13:28 ` Christophe Lyon
2015-08-25 14:07 ` Alan Lawrence
2015-08-25 13:59 ` [PATCH 14/15][ARM/AArch64 Testsuite]Add test of vcvt{,_high}_i{f32_f16,f16_f32} Alan Lawrence
2015-08-25 14:22 ` Christophe Lyon
2015-09-08 11:00 ` Alan Lawrence
2015-09-08 11:17 ` Kyrill Tkachov
2015-09-22 14:42 ` Marcus Shawcroft
2015-07-28 11:27 ` [PATCH 9/15][AArch64] vld{2,3,4}{,_lane,_dup}, vcombine, vcreate Alan Lawrence
2015-07-29 9:15 ` James Greenhalgh
2015-08-04 11:03 ` Alan Lawrence
2015-08-04 11:28 ` Alan Lawrence
2015-08-04 11:07 ` [PATCH][ARM/AArch64 Testsuite] Add float16 lane_indices tests (was: Re: [PATCH 9/15][AArch64] vld{2,3,4}{,_lane,_dup}, vcombine, vcreate) Alan Lawrence
2015-08-17 13:35 ` James Greenhalgh
2015-08-06 16:28 ` [PATCH 9/15][AArch64] vld{2,3,4}{,_lane,_dup}, vcombine, vcreate Alan Lawrence
2015-08-17 13:21 ` James Greenhalgh
2015-07-28 11:27 ` [PATCH 15/15][ARM] Update sourcebuild.texi with testsuite/effective-target hooks Alan Lawrence
2015-09-08 14:03 ` Alan Lawrence
2015-09-08 14:20 ` Kyrill Tkachov
2015-07-28 11:27 ` [PATCH 11/15][AArch64] vreinterpret(q?), vget_(low|high), vld1(q?)_dup Alan Lawrence
2015-07-29 13:18 ` James Greenhalgh
2015-08-24 9:19 ` Alan Lawrence
2015-09-04 10:18 ` James Greenhalgh
2015-09-07 13:10 ` [PATCH][AArch64] Improve code generation for float16 vector code Alan Lawrence
2015-09-08 8:26 ` James Greenhalgh
2015-09-08 8:26 ` James Greenhalgh
2015-09-08 12:03 ` Alan Lawrence
2015-09-08 8:33 ` [PATCH 11/15][AArch64] vreinterpret(q?), vget_(low|high), vld1(q?)_dup James Greenhalgh
2015-07-28 11:42 ` [PATCH 12/15][AArch64] Add vcvt(_high)?_f32_f16 intrinsics, with BE RTL fix Alan Lawrence
2015-07-29 14:08 ` James Greenhalgh
2015-08-25 11:06 ` Alan Lawrence
2015-09-04 9:54 ` James Greenhalgh [this message]
2015-07-28 11:48 ` [PATCH 13/15][ARM/AArch64 Testsuite] Add float16 tests to advsimd-intrinsics testsuite Alan Lawrence
2015-08-25 13:27 ` Christophe Lyon
2015-08-25 13:29 ` Alan Lawrence
2015-09-08 10:56 ` Alan Lawrence
2015-09-08 10:56 ` Kyrill Tkachov
2015-09-08 11:09 ` Kyrill Tkachov
2015-08-25 12:54 ` [PATCH 0/15][ARM/AArch64] Add support for float16_t vectors (v3) Alan Lawrence
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150904095000.GA18679@arm.com \
--to=james.greenhalgh@arm.com \
--cc=alan.lawrence@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).