From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66856 invoked by alias); 7 Sep 2015 14:48:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 66838 invoked by uid 89); 7 Sep 2015 14:48:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 07 Sep 2015 14:48:32 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 87EA514AA4; Mon, 7 Sep 2015 14:48:31 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-44.ams2.redhat.com [10.36.116.44]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t87EmTCh010505 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 7 Sep 2015 10:48:31 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id t87EmSZP023284; Mon, 7 Sep 2015 16:48:28 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id t87EmQOB023283; Mon, 7 Sep 2015 16:48:26 +0200 Date: Mon, 07 Sep 2015 14:54:00 -0000 From: Jakub Jelinek To: Ilya Verbin Cc: "Hahnfeld, Jonas" , "gcc-patches@gcc.gnu.org" , Kirill Yukhin , Mike Stump Subject: Re: Fix intelmic-mkoffload.c if the temp path contains a '-' Message-ID: <20150907144826.GT1847@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20150901115012.GQ1847@tucnak.redhat.com> <4481C24E-AB27-4E2B-AEE6-2E813C0925DB@comcast.net> <20150907144612.GA5256@msticlxl57.ims.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150907144612.GA5256@msticlxl57.ims.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00445.txt.bz2 On Mon, Sep 07, 2015 at 05:46:12PM +0300, Ilya Verbin wrote: > On Sat, Sep 05, 2015 at 00:45:36 +0300, Ilya Verbin wrote: > > 2015-09-04 22:27 GMT+03:00 Mike Stump : > > > On Sep 4, 2015, at 4:10 AM, Hahnfeld, Jonas wrote: > > >>>>> * intelmic-mkoffload.c (prepare_target_image): Fix if the temp path > > >>>>> contains a '-‘. > > > > > > So, out of curiosity, did you test all characters other than null? If - doesn’t work, there is a good chance that no such test has been done, and there is a small hoard of bugs, all the same in there. > > > > Good point. Objcopy in bfd/binary.c creates symbol names this way: > > > > for (p = buf; *p; p++) > > if (! ISALNUM (*p)) > > *p = '_'; > > > > We should do the same in intelmic-mkoffload.c. I will prepare a patch. > > gcc/ > * config/i386/intelmic-mkoffload.c (prepare_target_image): Handle all > non-alphanumeric characters in the symbol name. > > Regtested on x86_64-linux. OK for trunk? OK for gcc-5-branch? Ok for both. Jakub