From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114553 invoked by alias); 8 Sep 2015 08:35:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 114541 invoked by uid 89); 8 Sep 2015 08:35:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: cam-smtp0.cambridge.arm.com Received: from fw-tnat.cambridge.arm.com (HELO cam-smtp0.cambridge.arm.com) (217.140.96.140) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 08 Sep 2015 08:35:17 +0000 Received: from arm.com (e107456-lin.cambridge.arm.com [10.2.207.14]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id t888ZEPS027346; Tue, 8 Sep 2015 09:35:14 +0100 Date: Tue, 08 Sep 2015 08:42:00 -0000 From: James Greenhalgh To: Kyrill Tkachov Cc: GCC Patches , Marcus Shawcroft , Richard Earnshaw Subject: Re: [PATCH][AArch64][1/3] Expand signed mod by power of 2 using CSNEG Message-ID: <20150908083513.GA38681@arm.com> References: <55B219A5.8060307@arm.com> <20150803130104.GA13835@arm.com> <55CC8F62.4080604@arm.com> <20150901092501.GA28861@arm.com> <55E580AC.2060200@arm.com> <55E6F2E7.1080904@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55E6F2E7.1080904@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00476.txt.bz2 On Wed, Sep 02, 2015 at 02:00:23PM +0100, Kyrill Tkachov wrote: > > On 01/09/15 11:40, Kyrill Tkachov wrote: > > Hi James, > > > > On 01/09/15 10:25, James Greenhalgh wrote: > >> On Thu, Aug 13, 2015 at 01:36:50PM +0100, Kyrill Tkachov wrote: > >> > >> Some comments below. > > Thanks, I'll incorporate them, with one clarification inline. > > And here's the updated patch. OK. Thanks, James > 2015-09-02 Kyrylo Tkachov > > * config/aarch64/aarch64.md (mod3): New define_expand. > (*neg2_compare0): Rename to... > (neg2_compare0): ... This. > * config/aarch64/aarch64.c (aarch64_rtx_costs, MOD case): > Move check for speed inside the if-then-elses. Reflect > CSNEG sequence in MOD by power of 2 case.