From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103572 invoked by alias); 8 Sep 2015 12:43:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 103563 invoked by uid 89); 8 Sep 2015 12:43:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Tue, 08 Sep 2015 12:43:09 +0000 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id F2AC0ACE5; Tue, 8 Sep 2015 12:43:05 +0000 (UTC) Date: Tue, 08 Sep 2015 12:47:00 -0000 From: Martin Jambor To: Alan Lawrence Cc: gcc-patches@gcc.gnu.org, rguenther@suse.de, christophe.lyon@linaro.org, law@redhat.com Subject: Re: [PATCH 2/5] completely_scalarize arrays as well as records. Message-ID: <20150908124304.GA21293@virgil.suse.cz> Mail-Followup-To: Alan Lawrence , gcc-patches@gcc.gnu.org, rguenther@suse.de, christophe.lyon@linaro.org, law@redhat.com References: <55E0795E.8060009@arm.com> <1441631745-7615-1-git-send-email-alan.lawrence@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1441631745-7615-1-git-send-email-alan.lawrence@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00500.txt.bz2 Hi, On Mon, Sep 07, 2015 at 02:15:45PM +0100, Alan Lawrence wrote: > In-Reply-To: <55E0697D.2010008@arm.com> > > On 28/08/15 16:08, Alan Lawrence wrote: > > Alan Lawrence wrote: > >> > >> Right. I think VLA's are the problem with pr64312.C also. I'm testing a fix > >> (that declares arrays with any of these properties as unscalarizable). > > ... > > In the meantime I've reverted the patch pending further testing on x86, aarch64 > > and arm. > > I've now tested g++ and fortran (+ bootstrap + check-gcc) on x86, AArch64 and > ARM, and Ada on x86 and ARM. > > So far the list of failures from the original patch seems to be: > > * g++.dg/torture/pr64312.C on ARM and m68k-linux > * Building Ada on x86 > * Ada ACATS c87b31a on ARM (where the Ada frontend builds fine) > > Here's a new version, that fixes all the above, by adding a dose of > paranoia in scalarizable_type_p... I have only had a bref look at scalarizable_type_p then, considering all of the rest unchanged, and the tests there seem natural to me. (Note that I do not have the authority to approve the patch.) > (I wonder about adding a comment > in completely_scalarize that such cases have already been ruled > out?) The comment already references scalarizable_type_p which is enough at least for me. Thanks, Martin