From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120146 invoked by alias); 8 Sep 2015 13:43:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 120126 invoked by uid 89); 8 Sep 2015 13:43:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 08 Sep 2015 13:43:01 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 273518EA3B; Tue, 8 Sep 2015 13:43:00 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-44.ams2.redhat.com [10.36.116.44]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t88Dgwai008510 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 8 Sep 2015 09:42:59 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id t88Dgud4012597; Tue, 8 Sep 2015 15:42:56 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id t88DgtQb012596; Tue, 8 Sep 2015 15:42:55 +0200 Date: Tue, 08 Sep 2015 13:49:00 -0000 From: Jakub Jelinek To: Ilya Verbin Cc: gcc-patches@gcc.gnu.org, Kirill Yukhin Subject: Re: [PATCH] Import liboffloadmic from upstream Message-ID: <20150908134255.GD1847@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20150831132349.GA5011@msticlxl57.ims.intel.com> <20150831144953.GB1847@tucnak.redhat.com> <20150831175658.GB5011@msticlxl57.ims.intel.com> <20150831180749.GE1847@tucnak.redhat.com> <20150908133958.GA17925@msticlxl57.ims.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150908133958.GA17925@msticlxl57.ims.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00509.txt.bz2 On Tue, Sep 08, 2015 at 04:40:22PM +0300, Ilya Verbin wrote: > Looks like this is the only incompatible change. Given that the library is used > only by libgomp plugin, this isn't a big problem. I will add a comment into > plugin prohibiting the use of the return value. In fact, if something goes > wrong in __offload_register_image, it calls exit (). Ack. > > > > 2) the *.map changes look wrong, when adding symbols to a symbol versioned > > > > shared library, new symbols shouldn't be added to existing symbol > > > > version, but to a new symbol version (so e.g. MYO_1.0.1 (or MYO_1.1) > > > > and COI_1.0.1 (or COI_1.1)) > > > > > > I agree, but this is what I can't change - these files are copied from real COI/ > > > MYO libraries, therefore the emulator (fake COI/MYO libs) must have the same > > > versions as the real libs. > > > > If that change is already cast into stone, there is nothing we can do, but > > can you talk to the library maintainers that they add new symbols to > > different symbol version next time at least? > > Yes, I have told them. > > So, is it OK for trunk? Ok. Jakub