[PATCH] fix TLS support detection for sh targets

[PATCH] fix TLS support detection for sh targets

[Rich Felker]

[-- Attachment #1: Type: text/plain, Size: 120 bytes --]

Bad patterns caused configure to always disable TLS for big-endian sh
targets and for anything other than sh 3/4.

Rich

[-- Attachment #2: sh-tls-detect.diff --]
[-- Type: text/plain, Size: 716 bytes --]

--- gcc-5.2.0.base/gcc/configure.ac	2015-08-11 16:23:36.000000000 +0000
+++ gcc-5.2.0/gcc/configure.ac	2015-09-13 08:17:31.714972082 +0000
@@ -3300,7 +3300,7 @@
 	tls_first_minor=14
 	tls_as_opt="-m64 -Aesame --fatal-warnings"
 	;;
-  sh-*-* | sh[34]-*-*)
+  sh-*-* | sh[123456789lbe]*-*-*)
     conftest_s='
 	.section ".tdata","awT",@progbits
 foo:	.long	25
--- gcc-5.2.0.base/gcc/configure	2015-08-11 16:23:35.000000000 +0000
+++ gcc-5.2.0/gcc/configure	2015-09-13 08:17:42.608304751 +0000
@@ -23754,7 +23754,7 @@
 	tls_first_minor=14
 	tls_as_opt="-m64 -Aesame --fatal-warnings"
 	;;
-  sh-*-* | sh[34]-*-*)
+  sh-*-* | sh[123456789lbe]*-*-*)
     conftest_s='
 	.section ".tdata","awT",@progbits
 foo:	.long	25

Re: [PATCH] fix TLS support detection for sh targets

[Kaz Kojima]

Rich Felker <dalias@libc.org> wrote:
> Bad patterns caused configure to always disable TLS for big-endian sh
> targets and for anything other than sh 3/4.

Could you please give a patch for the trunk with an appropriate
ChangeLog entry?

Regards,
	kaz

Re: [PATCH] fix TLS support detection for sh targets

[Rich Felker]

On Sun, Sep 13, 2015 at 06:55:56PM +0900, Kaz Kojima wrote:
> Rich Felker <dalias@libc.org> wrote:
> > Bad patterns caused configure to always disable TLS for big-endian sh
> > targets and for anything other than sh 3/4.
> 
> Could you please give a patch for the trunk with an appropriate
> ChangeLog entry?

I'm pretty sure this will still apply to trunk, but I can check that
and add the changelog entry. Is there something I should read on the
form or just follow the example from my last patch where you added it?

Rich

Re: [PATCH] fix TLS support detection for sh targets

[Kaz Kojima]

Rich Felker <dalias@libc.org> wrote:
> I'm pretty sure this will still apply to trunk, but I can check that
> and add the changelog entry. Is there something I should read on the
> form or just follow the example from my last patch where you added it?

The latter would be enough for this, though

https://gcc.gnu.org/wiki/ChangeLog
https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_Formatted_GNU_ChangeLog

will be handy instructions.

Regards,
	kaz

Re: [PATCH] fix TLS support detection for sh targets

[Rich Felker]

On Mon, Sep 14, 2015 at 07:08:33AM +0900, Kaz Kojima wrote:
> Rich Felker <dalias@libc.org> wrote:
> > I'm pretty sure this will still apply to trunk, but I can check that
> > and add the changelog entry. Is there something I should read on the
> > form or just follow the example from my last patch where you added it?
> 
> The latter would be enough for this, though
> 
> https://gcc.gnu.org/wiki/ChangeLog
> https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_Formatted_GNU_ChangeLog
> 
> will be handy instructions.

Thanks. I confirmed that the patch as submitted applies cleanly to
trunk. For the ChangeLog message, do I need to list both configure and
configure.ac or just the latter? And should configure be included in
the patch like I did, or regenerated when the patch is applied?

Rich

Re: [PATCH] fix TLS support detection for sh targets

[Szabolcs Nagy]

On 14/09/15 17:58, Rich Felker wrote:
> trunk. For the ChangeLog message, do I need to list both configure and
> configure.ac or just the latter? And should configure be included in
> the patch like I did, or regenerated when the patch is applied?

list both

i think it's ok to fix configure manually

Re: [PATCH] fix TLS support detection for sh targets

[Rich Felker]

On Mon, Sep 14, 2015 at 06:06:02PM +0100, Szabolcs Nagy wrote:
> On 14/09/15 17:58, Rich Felker wrote:
> >trunk. For the ChangeLog message, do I need to list both configure and
> >configure.ac or just the latter? And should configure be included in
> >the patch like I did, or regenerated when the patch is applied?
> 
> list both
> 
> i think it's ok to fix configure manually

OK thanks! Sorry I missed the thing about configure: Regenerate in the
second link. I'll format the patch properly and send it soon.

Rich