From: Marek Polacek <polacek@redhat.com>
To: Bernd Edlinger <bernd.edlinger@hotmail.de>
Cc: Jeff Law <law@redhat.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Jakub Jelinek <jakub@redhat.com>,
"H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: [PATCH] Fix PR64078
Date: Thu, 17 Sep 2015 15:06:00 -0000 [thread overview]
Message-ID: <20150917150026.GC27588@redhat.com> (raw)
In-Reply-To: <DUB118-W29D540E8FAA34840CA988CE4520@phx.gbl>
On Wed, Sep 09, 2015 at 07:48:15PM +0200, Bernd Edlinger wrote:
> Hi,
>
> On Wed, 9 Sep 2015 09:31:33, Jeff Law wrote:
> > You could probably make the function static or change its visibility via
> > a function attribute (there's a visibility attribute which can take the
> > values default, hidden protected or internal). Default visibility
> > essentially means the function can be overridden. I think changing it
> > to "protected" might work. Note if we do that, we may need some kind of
> > target selector on the test since not all targets support the various
> > visibility attributes.
> >
>
> Yes, it works both ways: static works, and __attribute__ ((visibility ("protected"))) works too:
>
> make check-gcc-c++ RUNTESTFLAGS="ubsan.exp=object-size-9.c --target_board='unix{-fpic,-mcmodel=medium,-fpic\ -mcmodel=medium,-mcmodel=large,-fpic\ -mcmodel=large}'"
>
> has all tests passed, but..
>
> make check-gcc-c++ RUNTESTFLAGS="ubsan.exp=object-size-9.c
> --target_board='unix{-fno-inline}'"
>
> still fails in the same way for all workarounds: inline, static, and __attribute__ ((visibility ("protected"))).
>
> Maybe "static" would be preferable?
Yeah, I'd go with static if that helps. I'd rather avoid playing games
with visibility.
Marek
next prev parent reply other threads:[~2015-09-17 15:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 2:53 Bernd Edlinger
2015-09-07 10:41 ` Marek Polacek
2015-09-07 13:46 ` Bernd Edlinger
2015-09-08 19:30 ` Jeff Law
2015-09-09 9:18 ` Bernd Edlinger
2015-09-09 15:45 ` Jeff Law
2015-09-09 18:14 ` Bernd Edlinger
2015-09-17 15:06 ` Marek Polacek [this message]
2015-09-17 16:40 ` Jeff Law
2015-09-17 18:08 ` Bernd Edlinger
2015-09-17 18:51 ` Marek Polacek
2016-08-29 7:59 ` Tom de Vries
2016-08-29 16:43 ` Bernd Edlinger
2016-08-30 8:21 ` Tom de Vries
2016-08-30 9:38 ` Bernd Edlinger
2016-08-31 5:42 ` Tom de Vries
2016-09-15 10:38 ` Tom de Vries
2016-09-19 20:50 ` Jeff Law
2016-09-19 21:09 ` Bernd Edlinger
2016-09-19 21:34 ` Jeff Law
2016-09-22 13:26 ` Bernd Edlinger
2016-08-30 8:40 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150917150026.GC27588@redhat.com \
--to=polacek@redhat.com \
--cc=bernd.edlinger@hotmail.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=jakub@redhat.com \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).