From: Jonathan Wakely <jwakely@redhat.com>
To: Jennifer Yao <jenny.hyphen.fa@gmail.com>
Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: Fwd: [PATCH] Enable libstdc++ numeric conversions on Cygwin
Date: Fri, 18 Sep 2015 15:51:00 -0000 [thread overview]
Message-ID: <20150918154917.GO2969@redhat.com> (raw)
In-Reply-To: <CAPQfdhmMGJeb-tq29jTheoo5jUaeiFzcycWFTrpShRE-kPftGw@mail.gmail.com>
On 18/09/15 11:17 -0400, Jennifer Yao wrote:
>A number of functions in libstdc++ are guarded by the _GLIBCXX_USE_C99
>preprocessor macro, which is only defined on systems that pass all of
>the checks for a large set of C99 functions. Consequently, on systems
>which lack any of the required C99 facilities (e.g. Cygwin, which
>lacks some C99 complex math functions), the numeric conversion
>functions (std::stoi(), std::stol(), std::to_string(), etc.) are not
>definedâa rather silly outcome, as none of the numeric conversion
>functions are implemented using C99 math functions.
>
>This patch enables numeric conversion functions on the aforementioned
>systems by splitting the checks for C99 support and defining several
>new macros (_GLIBCXX_USE_C99_STDIO, _GLIBCXX_USE_C99_STDLIB, and
>_GLIBCXX_USE_C99_WCHAR), which replace the use of _GLIBCXX_USE_C99 in
>#if conditionals where appropriate.
Awesome! This has been on my TODO list for ages, but I've not made
much progress. I *definitely* want to see this change happen, but
there are some legal prerequisites that need to be met before that can
happen, see
https://gcc.gnu.org/onlinedocs/libstdc++/manual/appendix_contributing.html#contrib.list
Do you already have a copyright assignment for GCC?
If not, would you be willing to complete one?
THanks for doing this work, it will help several other platforms, not
only Cygwin.
N.B. I don't see a patch attached to your mail, but that's not a
problem for now as I don't want to look at it until I know the status
of your copyright assignment (if we don't end up using your patch and
I do it myself then I don't want to plagiarise your work!)
next prev parent reply other threads:[~2015-09-18 15:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 15:19 Jennifer Yao
[not found] ` <CAPQfdhmMGJeb-tq29jTheoo5jUaeiFzcycWFTrpShRE-kPftGw@mail.gmail.com>
2015-09-18 15:51 ` Jonathan Wakely [this message]
2015-09-19 21:00 ` Fwd: " Jennifer Yao
2015-09-21 12:37 ` Jonathan Wakely
[not found] ` <CAPQfdh=uOjLzi60Dnd0Dd1ycJUDqMWQBCv1aRAGBP97DSUS3+Q@mail.gmail.com>
[not found] ` <20151112114049.GY2937@redhat.com>
2015-11-12 13:40 ` Jonathan Wakely
2015-11-12 14:50 ` Jonathan Wakely
2015-11-12 17:25 ` Jennifer Yao
2015-11-12 17:56 ` Jonathan Wakely
2015-11-12 22:56 ` Andreas Tobler
2015-11-13 14:52 ` Jonathan Wakely
2015-11-14 8:37 ` Christophe Lyon
2015-11-14 13:58 ` Jonathan Wakely
2015-11-14 21:23 ` Jennifer Yao
2015-11-15 21:38 ` Jennifer Yao
2015-11-16 9:48 ` Jonathan Wakely
2015-11-14 16:32 ` Jonathan Wakely
2015-11-15 8:58 ` Christophe Lyon
2015-11-15 11:14 ` Jonathan Wakely
2015-11-15 16:25 ` Christophe Lyon
2015-12-08 10:59 ` Alan Lawrence
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150918154917.GO2969@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jenny.hyphen.fa@gmail.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).