From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9695 invoked by alias); 24 Sep 2015 12:54:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 9685 invoked by uid 89); 24 Sep 2015 12:54:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_50,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f45.google.com Received: from mail-pa0-f45.google.com (HELO mail-pa0-f45.google.com) (209.85.220.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 24 Sep 2015 12:54:10 +0000 Received: by pacex6 with SMTP id ex6so72636345pac.0 for ; Thu, 24 Sep 2015 05:54:08 -0700 (PDT) X-Received: by 10.66.253.199 with SMTP id ac7mr27352785pad.56.1443099247981; Thu, 24 Sep 2015 05:54:07 -0700 (PDT) Received: from bubble.grove.modra.org (CPE-58-160-163-67.gqzg1.fli.bigpond.net.au. [58.160.163.67]) by smtp.gmail.com with ESMTPSA id bc1sm13590686pbb.66.2015.09.24.05.54.06 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Sep 2015 05:54:06 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 6A2A8EA0136; Thu, 24 Sep 2015 22:24:02 +0930 (ACST) Date: Thu, 24 Sep 2015 13:19:00 -0000 From: Alan Modra To: Michael Ellerman Cc: gcc-patches@gcc.gnu.org, David Edelsohn , Michael Meissner Subject: Re: [RS6000] Don't pass --oformat to ld Message-ID: <20150924125402.GA2692@bubble.grove.modra.org> References: <20150902013502.GT24814@bubble.grove.modra.org> <1443068665.22866.3.camel@ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443068665.22866.3.camel@ellerman.id.au> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg01851.txt.bz2 On Thu, Sep 24, 2015 at 02:24:25PM +1000, Michael Ellerman wrote: > On Wed, 2015-09-02 at 11:05 +0930, Alan Modra wrote: > > bugzilla.redhat.com/show_bug_cgi?id=1255946 shows that gcc built with > > both powerpc64-linux and powerpc64le-linux support passes wrong linker > > options when trying to link in the non-default endian. A --oformat > > option coming from LINK_TARGET_SPEC is only correct for 32-bit. > > > > It turns out that GNU ld -m options select a particular ld emulation > > (e*.c file in ld build dir) which provides compiled-in scripts or > > selects a script from ldscripts/. Each of these has an OUTPUT_FORMAT > > statement, which does the same thing as --oformat. --oformat is > > therefore redundant when using GNU ld built this century, except > > possibly when a user overrides the default ld script with -Wl,-T and > > their script neglects OUTPUT_FORMAT, and it isn't the default output. > > I don't think it's worth fixing this possible use case. > > > > Bootstrap and testing in progress. OK for mainline assuming all is > > OK? > > > > * config/rs6000/sysv4le.h (LINK_TARGET_SPEC): Don't define. > > * config/rs6000/sysv4.h (LINK_TARGET_SPEC): Likewise. > > (LINK_SPEC, SUBTARGET_EXTRA_SPECS): Delete link_target. > > Hi Alan, > > If you could please backport this to the gcc-5-branch, that would helpful for > us (kernel folks). Bootstrapped and regression tested powerpc64le-linux. Is this OK for the branch too, David? -- Alan Modra Australia Development Lab, IBM