From: Segher Boessenkool <segher@kernel.crashing.org>
To: Peter Bergner <bergner@vnet.ibm.com>
Cc: gcc-patches@gcc.gnu.org, bschmidt@redhat.com, stevenb.gcc@gmail.com
Subject: Re: [PATCH 2/4 v2] bb-reorder: Add the "simple" algorithm
Date: Fri, 25 Sep 2015 16:15:00 -0000 [thread overview]
Message-ID: <20150925160355.GA28511@gate.crashing.org> (raw)
In-Reply-To: <1443196777.13186.21.camel@otta>
On Fri, Sep 25, 2015 at 10:59:37AM -0500, Peter Bergner wrote:
> On Fri, 2015-09-25 at 09:16 -0500, Segher Boessenkool wrote:
> > (reorder_basic_blocks): Choose between the STC and the simple
> > algorithms (always choose the former).
> [snip]
> @@ -2274,7 +2444,10 @@ reorder_basic_blocks (void)
> > set_edge_can_fallthru_flag ();
> > mark_dfs_back_edges ();
> >
> > - reorder_basic_blocks_software_trace_cache ();
> > + if (1)
> > + reorder_basic_blocks_software_trace_cache ();
> > + else
> > + reorder_basic_blocks_simple ();
>
> Did you write the code this way because you're thinking of allowing
> either reorder function to be called in the future?
I _wrote_ it as "if (0)" actually, to test the new algo ;-)
The next patch (3/4) wires up a new compiler flag to choose between the
two algorithms.
Segher
next prev parent reply other threads:[~2015-09-25 16:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 22:09 [PATCH 0/4] " Segher Boessenkool
2015-09-23 22:09 ` [PATCH 1/4] bb-reorder: Split out STC Segher Boessenkool
2015-09-24 16:12 ` Steven Bosscher
2015-09-23 22:10 ` [PATCH 2/4] bb-reorder: Add the "simple" algorithm Segher Boessenkool
2015-09-24 11:13 ` Bernd Schmidt
2015-09-24 13:48 ` Segher Boessenkool
2015-09-24 15:19 ` Segher Boessenkool
2015-09-24 16:35 ` Steven Bosscher
2015-09-24 17:22 ` Segher Boessenkool
2015-09-25 14:31 ` [PATCH 2/4 v2] " Segher Boessenkool
2015-09-25 16:09 ` Peter Bergner
2015-09-25 16:15 ` Segher Boessenkool [this message]
2015-09-29 13:19 ` Bernd Schmidt
2015-09-23 23:01 ` [PATCH 3/4] bb-reorder: Add -freorder-blocks-algorithm= and wire it up Segher Boessenkool
2015-09-24 11:00 ` Bernd Schmidt
2015-09-24 14:06 ` Segher Boessenkool
2015-09-24 15:21 ` Andi Kleen
2015-09-24 15:49 ` Segher Boessenkool
2015-09-24 17:16 ` Segher Boessenkool
[not found] ` <56377569.7010904@arm.com>
2015-11-02 15:14 ` Alan Lawrence
2015-11-02 21:04 ` Segher Boessenkool
2015-09-23 23:36 ` [PATCH 4/4] bb-reorder: Documentation updates Segher Boessenkool
2015-09-24 10:33 ` [PATCH 0/4] bb-reorder: Add the "simple" algorithm Bernd Schmidt
2015-09-24 13:32 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150925160355.GA28511@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=bergner@vnet.ibm.com \
--cc=bschmidt@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=stevenb.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).