From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Mikael Morin <mikael.morin@sfr.fr>
Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] fortran/67616 -- Fix ICE within a BLOCK construct
Date: Sat, 26 Sep 2015 21:58:00 -0000 [thread overview]
Message-ID: <20150926182058.GA89852@troutmask.apl.washington.edu> (raw)
In-Reply-To: <56069EDE.2000409@sfr.fr>
On Sat, Sep 26, 2015 at 03:34:22PM +0200, Mikael Morin wrote:
> Le 25/09/2015 23:41, Steve Kargl a ??crit :
> > The attached patch has been built and regression
> > tested on x86_64-*-freebsd. No regression occurred.
> >
> > The patch removes a conditional within an assert()
> > that triggers when a BLOCK construct is encountered.
> >
> What happens here, I think, is symtree is a new block-local symbol
> instead of the host-associated one.
> symtree is basically unused here, yet playing with the wrong one is not
> right.
> Can you try using gfc_get_ha_sym_tree a few lines above instead of
> gfc_get_sym_tree?
> A patch like that is preapproved.
>
Mikael,
Thanks. Your suggested change prevents the ICE. I'll
commit shortly.
--
Steve
prev parent reply other threads:[~2015-09-26 18:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-26 5:41 Steve Kargl
2015-09-26 19:52 ` Mikael Morin
2015-09-26 21:58 ` Steve Kargl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150926182058.GA89852@troutmask.apl.washington.edu \
--to=sgk@troutmask.apl.washington.edu \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=mikael.morin@sfr.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).