From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34077 invoked by alias); 26 Sep 2015 18:21:03 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 34054 invoked by uid 89); 26 Sep 2015 18:21:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: troutmask.apl.washington.edu Received: from troutmask.apl.washington.edu (HELO troutmask.apl.washington.edu) (128.95.76.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 26 Sep 2015 18:21:02 +0000 Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id t8QIKxo1089867 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 26 Sep 2015 11:20:59 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id t8QIKwGN089866; Sat, 26 Sep 2015 11:20:58 -0700 (PDT) (envelope-from sgk) Date: Sat, 26 Sep 2015 21:58:00 -0000 From: Steve Kargl To: Mikael Morin Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] fortran/67616 -- Fix ICE within a BLOCK construct Message-ID: <20150926182058.GA89852@troutmask.apl.washington.edu> References: <20150925214129.GA19593@troutmask.apl.washington.edu> <56069EDE.2000409@sfr.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56069EDE.2000409@sfr.fr> User-Agent: Mutt/1.5.24 (2015-08-30) X-SW-Source: 2015-09/txt/msg02057.txt.bz2 On Sat, Sep 26, 2015 at 03:34:22PM +0200, Mikael Morin wrote: > Le 25/09/2015 23:41, Steve Kargl a ??crit : > > The attached patch has been built and regression > > tested on x86_64-*-freebsd. No regression occurred. > > > > The patch removes a conditional within an assert() > > that triggers when a BLOCK construct is encountered. > > > What happens here, I think, is symtree is a new block-local symbol > instead of the host-associated one. > symtree is basically unused here, yet playing with the wrong one is not > right. > Can you try using gfc_get_ha_sym_tree a few lines above instead of > gfc_get_sym_tree? > A patch like that is preapproved. > Mikael, Thanks. Your suggested change prevents the ICE. I'll commit shortly. -- Steve