public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Trevor Saunders <tbsaunde@tbsaunde.org>
To: Jeff Law <law@redhat.com>
Cc: "gcc-patches@gcc.gnu.org >> gcc-patches" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix warnings building pdp11 port
Date: Tue, 29 Sep 2015 18:36:00 -0000	[thread overview]
Message-ID: <20150929181141.GA32422@tsaunders-iceball.corp.tor1.mozilla.com> (raw)
In-Reply-To: <560AC292.3010608@redhat.com>

On Tue, Sep 29, 2015 at 10:55:46AM -0600, Jeff Law wrote:
> The pdp11 port fails to build with the trunk because of a warning.
> Essentially VRP determines that the result of using BRANCH_COST is a
> constant with the range [0..1].  That's always less than 4, 3 and the
> various other magic constants used with BRANCH_COST and VRP issues a warning
> about that comparison.
> 
> I expect we're going to be overhauling BRANCH_COST shortly.  In the mean
> time, this just revectors BRANCH_COST for the pdp11 into a function to
> prevent VRP from collapsing the test and issuing the warning.
> 
> Yes, this means more code in the pdp11 cross compiler.  I'm not terribly
> concerned about that and I couldn't stand the idea of scattering diagnostic
> push/pop stuff all over the place to make just the pdp11 port happy.

ENOPATCH, but it seems like that's the right direction anyway since it
makes it slightly easier to convert the macro to a hook ;)

Trev

> 
> 
> Tested by building the pdp11 targets from config-all.mk.
> 
> Installed on the trunk.
> 
> Jeff

  reply	other threads:[~2015-09-29 18:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-29 18:11 Jeff Law
2015-09-29 18:36 ` Trevor Saunders [this message]
2015-09-29 18:54   ` Jeff Law
2015-09-30  8:14 ` Richard Biener
2015-09-30 17:44   ` Jeff Law
2015-10-01  9:49     ` Richard Biener
2015-10-01 15:47       ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150929181141.GA32422@tsaunders-iceball.corp.tor1.mozilla.com \
    --to=tbsaunde@tbsaunde.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=law@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).