From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30737 invoked by alias); 1 Oct 2015 12:49:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 30724 invoked by uid 89); 1 Oct 2015 12:49:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: fencepost.gnu.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (208.118.235.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 01 Oct 2015 12:49:45 +0000 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59051) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ZhdIt-0000i7-HL for gcc-patches@gnu.org; Thu, 01 Oct 2015 08:49:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZhdIp-00020U-EJ for gcc-patches@gnu.org; Thu, 01 Oct 2015 08:49:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhdIp-00020I-8U for gcc-patches@gnu.org; Thu, 01 Oct 2015 08:49:39 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 6B988C0B64C8; Thu, 1 Oct 2015 12:49:38 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-44.ams2.redhat.com [10.36.116.44]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t91Cnano016079 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 1 Oct 2015 08:49:37 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id t91CnZha028426; Thu, 1 Oct 2015 14:49:35 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id t91CnX8M028425; Thu, 1 Oct 2015 14:49:33 +0200 Date: Thu, 01 Oct 2015 12:49:00 -0000 From: Jakub Jelinek To: Tom de Vries Cc: "gcc-patches@gnu.org" Subject: Re: [patch] Add counter inits to zero_iter_bb in expand_omp_for_init_counts Message-ID: <20151001124933.GB28276@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <560D2B09.4020501@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <560D2B09.4020501@mentor.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00053.txt.bz2 On Thu, Oct 01, 2015 at 02:46:01PM +0200, Tom de Vries wrote: > this patch adds initialization in zero_iter_bb of counters introduced in > expand_omp_for_init_counts. > > This removes the need to set TREE_NO_WARNING on those counters. Why do you think it is a good idea? I'd be afraid it slows things down unnecessarily. Furthermore, I'd prefer not to change this area of code before gomp-4_1-branch is merged, as it will be a nightmare for the merge otherwise. Jakub