From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9588 invoked by alias); 3 Oct 2015 19:09:00 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 9568 invoked by uid 89); 3 Oct 2015 19:09:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: troutmask.apl.washington.edu Received: from troutmask.apl.washington.edu (HELO troutmask.apl.washington.edu) (128.95.76.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 03 Oct 2015 19:08:59 +0000 Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id t93J8vqc073553 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 3 Oct 2015 12:08:57 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id t93J8utI073552; Sat, 3 Oct 2015 12:08:56 -0700 (PDT) (envelope-from sgk) Date: Sat, 03 Oct 2015 19:09:00 -0000 From: Steve Kargl To: Mikael Morin Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] fortran/67758 -- Prevent ICE caused by misplaced COMMON Message-ID: <20151003190856.GA73524@troutmask.apl.washington.edu> References: <20151001000630.GB73614@troutmask.apl.washington.edu> <20151001000740.GC73614@troutmask.apl.washington.edu> <560D240C.5070405@sfr.fr> <560D3521.5050406@sfr.fr> <20151001163040.GA77294@troutmask.apl.washington.edu> <560E4E26.6000302@sfr.fr> <20151002164442.GB12835@troutmask.apl.washington.edu> <560FAA38.1080008@sfr.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <560FAA38.1080008@sfr.fr> User-Agent: Mutt/1.5.24 (2015-08-30) X-SW-Source: 2015-10/txt/msg00325.txt.bz2 On Sat, Oct 03, 2015 at 12:13:12PM +0200, Mikael Morin wrote: > > I have finally managed to find a patch that doesn't regress in the > testsuite. > > The gfc_add_in_common call in gfc_match_common is delayed after the > array spec handling and without return value check, so that errors are > ignored. Another gfc_add_in_common call is necessary to report errors > again during resolution. This is patch number 2. > The error location for the second call is grabbed from the common block > struct, which is made accessible in the function by patch number 1. > > No regression on x86-unknown-linux-gnu, OK for trunk? > The patch is OK. Thanks for taking over PR. -- Steve