From: Andre Vehreschild <vehre@gmx.de>
To: GCC-Fortran-ML <fortran@gcc.gnu.org>,
GCC-Patches-ML <gcc-patches@gcc.gnu.org>
Subject: [Patch, fortran, pr65889, v1] [6 Regressions] [OOP] ICE with sizeof a polymorphic variable
Date: Tue, 06 Oct 2015 14:23:00 -0000 [thread overview]
Message-ID: <20151006162257.4f62cb8e@vepi2> (raw)
[-- Attachment #1: Type: text/plain, Size: 494 bytes --]
Hi all,
the attached patch fixes a 6 regression when the argument of sizeof()
is a pointer to a class object, e.g., when the class object is
intent(out). The patch improves the check if the parameter is a
class object by previously checking whether the argument is the plain
object or a pointer to one and using TREE_OPERAND() once or twice,
respectively.
Bootstraps and regtests ok on x86_64-linux-gnu/f21.
Ok for trunk?
Regards,
Andre
--
Andre Vehreschild * Email: vehre ad gmx dot de
[-- Attachment #2: pr65889_1.clog --]
[-- Type: text/plain, Size: 313 bytes --]
gcc/fortran/ChangeLog:
2015-10-06 Andre Vehreschild <vehre@gcc.gnu.org>
* trans-intrinsic.c (gfc_conv_intrinsic_sizeof): Handle pointer to and
on stack class objects as sizeof parameter.
gcc/testsuite/ChangeLog:
2015-10-06 Andre Vehreschild <vehre@gcc.gnu.org>
* gfortran.dg/sizeof_5.f90: New test.
[-- Attachment #3: pr65889_1.patch --]
[-- Type: text/x-patch, Size: 1679 bytes --]
diff --git a/gcc/fortran/trans-intrinsic.c b/gcc/fortran/trans-intrinsic.c
index 35052be..ac61c09 100644
--- a/gcc/fortran/trans-intrinsic.c
+++ b/gcc/fortran/trans-intrinsic.c
@@ -5937,11 +5937,16 @@ gfc_conv_intrinsic_sizeof (gfc_se *se, gfc_expr *expr)
}
else if (arg->ts.type == BT_CLASS)
{
- /* For deferred length arrays, conv_expr_descriptor returns an
- indirect_ref to the component. */
+ /* Conv_expr_descriptor returns a component_ref to _data component of the
+ class object. The class object may be a non-pointer object, e.g.
+ located on the stack, or a memory location pointed to, e.g. a
+ parameter, i.e., an indirect_ref. */
if (arg->rank < 0
|| (arg->rank > 0 && !VAR_P (argse.expr)
- && GFC_DECL_CLASS (TREE_OPERAND (argse.expr, 0))))
+ && ((INDIRECT_REF_P (TREE_OPERAND (argse.expr, 0))
+ && GFC_DECL_CLASS (TREE_OPERAND (
+ TREE_OPERAND (argse.expr, 0), 0)))
+ || GFC_DECL_CLASS (TREE_OPERAND (argse.expr, 0)))))
byte_size = gfc_class_vtab_size_get (TREE_OPERAND (argse.expr, 0));
else if (arg->rank > 0)
/* The scalarizer added an additional temp. To get the class' vptr
diff --git a/gcc/testsuite/gfortran.dg/sizeof_5.f90 b/gcc/testsuite/gfortran.dg/sizeof_5.f90
new file mode 100644
index 0000000..0e1496a
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/sizeof_5.f90
@@ -0,0 +1,15 @@
+! { dg-do compile }
+!
+! PR fortran/65889
+!
+!
+module m
+ type n
+ end type n
+contains
+ subroutine g(ns)
+ class(n), intent(out), allocatable, dimension(:) :: ns
+ class(n), allocatable, dimension(:) :: tmp
+ write (0,*) sizeof(ns), sizeof(tmp)
+ end subroutine g
+end module m
next reply other threads:[~2015-10-06 14:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 14:23 Andre Vehreschild [this message]
2015-10-06 15:53 ` Mikael Morin
2015-10-07 11:00 ` [Patch, fortran, pr65889, commited] " Andre Vehreschild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151006162257.4f62cb8e@vepi2 \
--to=vehre@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).