public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] A tweak for debug_ops_vector
@ 2015-10-08  8:57 Marek Polacek
  2015-10-08  9:48 ` Bernd Schmidt
  0 siblings, 1 reply; 2+ messages in thread
From: Marek Polacek @ 2015-10-08  8:57 UTC (permalink / raw)
  To: GCC Patches

I've been playing with reassoc recently and what bothers me is that
dump_ops_vector doesn't print a newline after each element, so it prints
e.g. "Op 0 -> rank: 5, tree: a_1(D)Op 1 -> rank: 4, tree: c_3(D)" which
isn't really all that readable to me.

Bootstrapped/regtested on x86_64-linux, ok for trunk?

2015-10-08  Marek Polacek  <polacek@redhat.com>

	* tree-ssa-reassoc.c (dump_ops_vector): Print newline after each
	ops element.

diff --git gcc/tree-ssa-reassoc.c gcc/tree-ssa-reassoc.c
index 5efee21..879722e 100644
--- gcc/tree-ssa-reassoc.c
+++ gcc/tree-ssa-reassoc.c
@@ -4930,6 +4930,7 @@ dump_ops_vector (FILE *file, vec<operand_entry *> ops)
     {
       fprintf (file, "Op %d -> rank: %d, tree: ", i, oe->rank);
       print_generic_expr (file, oe->op, 0);
+      fprintf (file, "\n");
     }
 }
 

	Marek

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] A tweak for debug_ops_vector
  2015-10-08  8:57 [PATCH] A tweak for debug_ops_vector Marek Polacek
@ 2015-10-08  9:48 ` Bernd Schmidt
  0 siblings, 0 replies; 2+ messages in thread
From: Bernd Schmidt @ 2015-10-08  9:48 UTC (permalink / raw)
  To: Marek Polacek, GCC Patches

On 10/08/2015 10:57 AM, Marek Polacek wrote:
> I've been playing with reassoc recently and what bothers me is that
> dump_ops_vector doesn't print a newline after each element, so it prints
> e.g. "Op 0 -> rank: 5, tree: a_1(D)Op 1 -> rank: 4, tree: c_3(D)" which
> isn't really all that readable to me.
>
> Bootstrapped/regtested on x86_64-linux, ok for trunk?
>
> 2015-10-08  Marek Polacek  <polacek@redhat.com>
>
> 	* tree-ssa-reassoc.c (dump_ops_vector): Print newline after each
> 	ops element.

Ok.


Bernd

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-10-08  9:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-08  8:57 [PATCH] A tweak for debug_ops_vector Marek Polacek
2015-10-08  9:48 ` Bernd Schmidt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).